[HOLD for payment 2023-11-30] [$500] Distance - The title 'Distance' changing to 'Merchant' when toggling on Billable

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-condition:

1. Go to old dot as admin
2. Navigate to collect Workspace settings--Expenses
3. Set "re-bill expenses to clients" to "default to Billable "
   Steps:
4. Launch app
5. Open employee WS
6. Tap plus icon -- Request money
7. Tap distance request
8. Select start and finish waypoints
9. Tap next
10. Tap distance
11. Tap on distance request created to open distance request detail page
12. Note under distance heading, distance mentioned
13. Tapping on distance, user can add/change waypoints
14. Toggle on Billable
15. Note "distance" heading changed to "merchant "
16. Tap on merchant
17. Edit waypoints option not shown

Expected Result:

The title 'Distance' shouldn't change to 'Merchant' when toggling on Billable

Actual Result:

The title 'Distance' changing to 'Merchant' when toggling on Billable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270070_1699540303124.vdo.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01629522855183a4d0
• Upwork Job ID: 1722629339378032640
• Last Price Increase: 2023-11-09
• Automatic offers:
• s77rt | Reviewer | 27653359
• Krishna2323 | Contributor | 27653361

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01629522855183a4d0

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance-Title "Distance" changed to "merchant" when toggle on Billable

What is the root cause of that problem?

When toggle on Billable, isDistanceRequest will be false. It cause that we display merchant instead of distance

What changes do you think we should make in order to solve the problem?

We should update the TransactionUtils.isDistanceRequest function return true even when toggle on Billable

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance-Title "Distance" changed to "merchant" when toggle on Billable

What is the root cause of that problem?

We are using IOU.editMoneyRequest for distance request which changed the comment object into an empty string, the comment object is used to check if the request is a distance or not and when we want to edit non-distance money request with IOU.editMoneyRequest we expect comment as an string.

App/src/components/ReportActionItem/MoneyRequestView.js

Line 283 in 732aad9

onToggle={(value) => IOU.editMoneyRequest(transaction.transactionID, report.reportID, {billable: value})}

What changes do you think we should make in order to solve the problem?

Option 1:

We can make a util function in TransactionUtils to check if the transaction is distance request or not and based on that we will use updateDistanceRequest or editMoneyRequest function.

Example Code:

function editMoneyOrDistanceRequest(transaction: Transaction, transactionThreadReportID: number, transactionChanges: TransactionChanges) {
    if (isDistanceRequest(transaction)) {
        IOU.updateDistanceRequest(transaction.transactionID, transactionThreadReportID, transactionChanges);
    } else {
        IOU.editMoneyRequest(transaction.transactionID, transactionThreadReportID, transactionChanges);
    }
} 

Option 2:

We need to use IOU.updateDistanceRequest instead of IOU.editMoneyRequest when transaction is a distance request.

Updated code:

if (isDistanceRequest) {
    IOU.updateDistanceRequest(transaction.transactionID, report.reportID, {billable: value});
} else {
    IOU.editMoneyRequest(transaction.transactionID, report.reportID, {billable: value});
}

Result

[s77rt]

@DylanDylann Thanks for the proposal. Your RCA is correct but not complete. isDistanceRequest is being false indeed but that should not happen in the first place.