[HOLD for payment 2024-01-24] [$500] Thread - Edit box with parent message not in focus when there many comments in thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.3.95-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Navigate to any chat
3. Send a message and start a thread
4. Send some messages > 14
5. Long tap the parent message
6. Select "Edit comment"

Expected Result:

The edit box with the parent message is in focus, and the user is able to see it

Actual Result:

The edit box with the parent is not in focus until the user starts typing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6261528_1698963049662.video_2023-11-02_17-19-30.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7c8ad57a6053cea
• Upwork Job ID: 1720205591610355712
• Last Price Increase: 2023-11-02
• Automatic offers:
• aimane-chnaif | Reviewer | 28062420
• Krishna2323 | Contributor | 28062421

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7c8ad57a6053cea

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Edit box with parent message not in focus when there many comments in thread

What is the root cause of that problem?

We are always passing '0' as the index for the parent message, but since the list is inverted, '0' actually corresponds to the index of the last message in the thread, not the parent message's index.

App/src/pages/home/report/ReportActionItemParentAction.js

Line 73 in d53a03e

index={0}

What changes do you think we should make in order to solve the problem?

We need to pass the length of the list minus one to accurately set the index of the parent message, since the list is inverted. We get the sortedReportActions in ReportActionsListItemRenderer, so we can pass index={sortedReportActions.length - 1} to ReportActionItemParentAction or we can simply pass the index like we are passing to child actions.

Result

fix_demo.mp4

[aimane-chnaif]

@Krishna2323's proposal looks good to me.
🎀 👀 🎀 C+ reviewed