[HOLD for payment 2023-11-30] [$125] Deeplink access of user notify me page and back opens wrong page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697014098088459

Action Performed:

1. Open the app
2. Open any user report
3. Click on header and click on notify me
4. Copy the URL and paste in any report
5. (For devices without access to URL like native app, we will need to perform step 1 to 4 in device with URL access) Click on the URL
6. Click on back and observe that instead of opening user details page, it opens room settings and displays user as room

Expected Result:

App should navigate back to user profile on back from notification preference page

Actual Result:

App navigates back to room settings instead of user profile on back from notification preference page when accessed by deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen_Recording_20231011_140427_New.Expensify.1.mp4

Android: mWeb Chrome

android.chrome.click.on.URL.and.back.wrong.page.mp4

iOS: Native

RPReplay_Final1697047170.1.MP4

iOS: mWeb Safari

ios.safari.click.on.URL.and.back.wrong.page.mov

MacOS: Chrome / Safari

windows.chrome.back.from.notification.preference.not.working.mp4

double.slashes.not.handled.in.URL.mp4

MacOS: Desktop

mac.desktop.back.is.wrong.notify.me.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0169068d72e6fa963b
• Upwork Job ID: 1719332158598991872
• Last Price Increase: 2023-11-07
• Automatic offers:
• ishpaul777 | Contributor | 27600164
• dhanashree-sawant | Reporter | 27600166

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0169068d72e6fa963b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[melvin-bot]

Upwork job price has been updated to $125

[ishpaul777]

Proposal

Problem

Deeplink access of user notify me page and back opens wrong page

Root Cause

This happens because in Notification pref. page, when back button is clicked we navigate user to report settings page not user profile page

Solution

Instead of linking to a report details we should check if the report is 1:1 DM and in that case navigate user to user details.

what we can do is use the utility isOneOnOneChat from your PR and create a new utility goBackToDetailsPage and use the same in notification page when user select a option or click the back icon.

/**
 * Goback to the details page of a given report
 *
 * @param {Object} report
 */
function goBackToDetailsPage(report){
    if (isOneOnOneChat(report)) {
        Navigation.goBack(ROUTES.PROFILE.getRoute(report.participantAccountIDs[0]));
    } else if (report.reportID) {
        Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(report.reportID))
    }
};

[bernhardoj]

After this PR is merged, we can just use ReportUtils.navigateToDetailsPage