[C+ Checklist Needs Completion] [$500] When clicking on "Mark as unread" the background image scrolls up and down unexpectedly

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.89-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698091949515899

Action Performed:

1. Open a chat
2. Go to the request money section (Pay or delete request money if you've requested before)
3. Enter a specific amount and send the request money
4. Click on the requested money
5. Hover over the requested money and click "Mark as unread"
6. Observe the background image scrolling up and down

Expected Result:

Clicking on "Mark as unread" should not cause the background image to scroll up and down

Actual Result:

When clicking on "Mark as unread," the background image scrolls up and down unexpectedly

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

20231024011931.mp4

Android: mWeb Chrome

20231024012134.mp4

iOS: Native

Screen.Recording.2023-10-24.at.1.17.53.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-10-24.at.1.18.36.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-24.at.1.13.42.AM.mov

Mark.as.unread.the.background.image.scrolls.up.and.down.unexpectedly.mp4

MacOS: Desktop

2023-10-24.01-05-39.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011368eedf256e8dda
• Upwork Job ID: 1716580589659369472
• Last Price Increase: 2023-10-23
• Automatic offers:
• dukenv0307 | Contributor | 27499352

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011368eedf256e8dda

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[akamefi202]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking on "Mark as unread" the background image scrolls up and down unexpectedly.

What is the root cause of that problem?

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 287 to 290 in 112061b

	<SpacerView
	shouldShow={shouldShowHorizontalRule}
	style={[shouldShowHorizontalRule ? styles.reportHorizontalRule : {}]}
	/>

SpacerView component represents the horizontal line(not unread marker) below money request view.
And it is shown or hidden by shouldShowHorizontalRule variable.

App/src/components/SpacerView.js

Line 36 in 112061b

marginVertical: shouldShow ? CONST.HORIZONTAL_SPACER.DEFAULT_MARGIN_VERTICAL : CONST.HORIZONTAL_SPACER.HIDDEN_MARGIN_VERTICAL,

SpacerView component has 8px margin for both top & bottom(16px in total) and the gap is removed if the component is hidden.
And this gap makes scroll when the component is shown/hidden in animated way using react-native-reanimated library.

What changes do you think we should make in order to solve the problem?

1. To remove scroll, we need to keep gap although SpacerView is hidden.

marginVertical: CONST.HORIZONTAL_SPACER.DEFAULT_MARGIN_VERTICAL,

App/src/pages/home/report/ReportActionItem.js

Line 610 in 112061b

return <View style={[props.shouldHideThreadDividerLine && !isNormalCreatedAction && styles.mb2]}>{content}</View>;

We should remove margin style in above code, which add bottom margin if spacer is hidden.
If we keep the gap in spacer, we don't need to add margin here.

It's related to this PR and this PR might be a regression in this case.
#27766

2. I'm still not sure if we should prevent scroll at all. Because I think react-native-reanimated library is used for smooth scroll.
   But at least, we need to fix one thing although we leave the scroll issue.

App/src/pages/home/report/ReportActionItem.js

Line 610 in 112061b

return <View style={[props.shouldHideThreadDividerLine && !isNormalCreatedAction && styles.mb2]}>{content}</View>;

The spacer has 16px margin if it's shown, but the above code only adds 8px margin if the spacer is hidden.
We should use styles.mb4 instead.

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking on "Mark as unread" the background image scrolls up and down unexpectedly

What is the root cause of that problem?

When we mark as unread the first visible action, the thread divider line is hidden, and marginVertical is changed here. So the created view scrolls up by Animated.View of react-native-reanimated lib

App/src/components/SpacerView.js

Lines 34 to 37 in d282473

	const duration = CONST.ANIMATED_TRANSITION;
	const values = {
	marginVertical: shouldShow ? CONST.HORIZONTAL_SPACER.DEFAULT_MARGIN_VERTICAL : CONST.HORIZONTAL_SPACER.HIDDEN_MARGIN_VERTICAL,
	borderBottomWidth: shouldShow ? CONST.HORIZONTAL_SPACER.DEFAULT_BORDER_BOTTOM_WIDTH : CONST.HORIZONTAL_SPACER.HIDDEN_BORDER_BOTTOM_WIDTH,

And then because when the thread divider line is hidden we have a marginBottom here, the created view scrolls down.

App/src/pages/home/report/ReportActionItem.js

Line 610 in d282473

return <View style={[props.shouldHideThreadDividerLine && !isNormalCreatedAction && styles.mb2]}>{content}</View>;

What changes do you think we should make in order to solve the problem?

This margin-bottom adds a space between the created view and the unread marker. To avoid the scrolls up and down, we can
remove this margin-bottom and change HIDDEN_MARGIN_VERTICAL from 0 to 4 to keep the space between the created view and the unread marker

App/src/pages/home/report/ReportActionItem.js

Line 610 in d282473

return <View style={[props.shouldHideThreadDividerLine && !isNormalCreatedAction && styles.mb2]}>{content}</View>;

App/src/CONST.ts

Line 2785 in d282473

HIDDEN_MARGIN_VERTICAL: 0,

What alternative solutions did you explore? (Optional)

We can change duration to 0 if shouldShow is false

const duration = shouldShow ? CONST.ANIMATED_TRANSITION : 0;

Or we can remove the use of animated view in SpacerView

[melvin-bot]

@greg-schroeder, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!