[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Task settings - Page header displayed if none selected in notification settings for task

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Create a task
2. Click task on the header to open details
3. Click settings and observe notification

Expected Result:

Place holder text or none

Actual Result:

Notification preferences page (Page header) is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop
• Windows: Chrome

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Windows: Chrome

Bug6234527_1697119547269.task_notification.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task settings - Page header displayed if none selected in notification settings for task

What is the root cause of that problem?

When we create a task we don't add notificationPreference field in optimisticData. And after API createTask is complete, it also doesn't return notificationPreference.

App/src/libs/ReportUtils.js

Line 2823 in f942acd

function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parentReportID, title, description, policyID = CONST.POLICY.OWNER_EMAIL_FAKE) {

And then this notification notificationPreferencesPage.notificationPreferences.undefined is displayed in ReportSettingPage and the app doesn't crash because we prevent it here #28377

App/src/pages/settings/Report/ReportSettingsPage.js

Line 70 in f942acd

report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN

What changes do you think we should make in order to solve the problem?

We should add notificationPreference field as always in buildOptimisticTaskReport

App/src/libs/ReportUtils.js

Line 2823 in f942acd

function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parentReportID, title, description, policyID = CONST.POLICY.OWNER_EMAIL_FAKE) {

What alternative solutions did you explore? (Optional)

[hungvu193]

Same RCA with #29334 and can be closed.

#29412 is up to fix this issue

[mountiny]

all good