[HOLD for payment 2023-11-01] [$500] The error message does not close in one click if the address dropdown is open.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1,3,80,0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696764596197229

Action Performed:

1. Go to the staging environment.
2. Open the FAB icon and select the "Request Money" option.
3. Navigate to the distance tab and click on "Start."
4. Trigger an error message by selecting "use current location" and denying access.
5. Open the dropdown by clicking on the address input and entering a few characters.
6. Attempt to close the error message by clicking the close button on the error.
7. Observe that the dropdown is closed, but the error message remains open.

Expected Result:

The error message should be removed with a single click just like in native devices

Actual Result:

Attempting to close the error results in the dropdown closing, but the error message persists.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

bug.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-10-08.at.4.58.24.PM.mov

MacOS: Chrome / Safari

Recording.4914.mp4

bug.mp4

MacOS: Desktop

Screen.Recording.2023-10-08.at.4.48.49.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019bb896d532ae6056
• Upwork Job ID: 1712446430446161920
• Last Price Increase: 2023-10-12
• Automatic offers:
• ntdiary | Reviewer | 27266011
• bernhardoj | Contributor | 27266013
• aman-atg | Reporter | 27266014

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019bb896d532ae6056

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Samueljh1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message does not close in one click if the address dropdown is open.

What is the root cause of that problem?

The dropdown menu is preventing click/touch events from bubbling down to other components.

What changes do you think we should make in order to solve the problem?

Modify code in the dropdown menu to ensure click events are passed down to other components.

What alternative solutions did you explore? (Optional)

N/A

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message does not close in one click if the address dropdown is open.

What is the root cause of that problem?

in react-native-google-places-autocomplete plugin when input box blur triggered time flat list is hidden so at the time next event is not triggering
https://github.com/FaridSafi/react-native-google-places-autocomplete/blob/ef107387c6846924423b832a242eee83cb07eed4/GooglePlacesAutocomplete.js#L721

What changes do you think we should make in order to solve the problem?

https://github.com/FaridSafi/react-native-google-places-autocomplete/blob/ef107387c6846924423b832a242eee83cb07eed4/GooglePlacesAutocomplete.js#L725
here we need to set into set timeout

Result

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While the address suggestion is showing, pressing the location error close button will close the suggestion but not clear the error.

What is the root cause of that problem?

This is the same issue as #12715. When we touch down the close button, it will immediately blur the address input closing the suggestion list and shifting the location error message & button position up, so the press callback is not fired.

What changes do you think we should make in order to solve the problem?

We can use the same solution as #12715 by preventing the blur when touching the close button using preventDefault here.

App/src/components/LocationErrorMessage/BaseLocationErrorMessage.js

Lines 60 to 67 in f942acd

	<PressableWithoutFeedback
	onPress={onClose}
	style={[styles.touchableButtonImage]}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	accessibilityLabel={translate('common.close')}
	>
	<Icon src={Expensicons.Close} />
	</PressableWithoutFeedback>

onMouseDown={e => e.preventDefault()}

or just do nothing