[HOLD for payment 2023-10-30] Profile - 'Country' doesn't change if selected manually and then another suggested address is selected

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com or open Expensify App (iOS, Android, Desktop)
2. Login with any account
3. Go to Settings > Profile > Personal details > Home address
4. Select any country
5. Start type any address in Address Line 1
6. Select any suggested address in another country

Expected Result:

All fields are filled in correctly. Country replaced with the suggested one

Actual Result:

The “Country” field has not changed and remains the same as it was previously selected manually

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Bug6233524_1697053961845.Desktop-Selected-County-not-change-to-suggested.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0192336d38fb4edbd9
• Upwork Job ID: 1712810996160061440
• Last Price Increase: 2023-10-13
• Automatic offers:
• 0xmiroslav | Reviewer | 27241875
• ishpaul777 | Contributor | 27241878

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ishpaul777]

Proposal

Problem

'Country' not change if select it manually and then select another suggested address

Root Cause

In useEffect of AddressPage we have added a dependecy for currentCountry so even when the address country is changed when a auto suggested address in clicked it get overridden by country from url Param.

Changes

We can safely remove currentCountry from url so the useEffect run only on componentmount and url param change but not when currentCountry change.

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - 'Country' not change if select it manually and then select another suggested address

What is the root cause of that problem?

When we select country from country list, selected country is stored in route data. And we have this piece of code to retrieve this data from route and set local state

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Lines 156 to 161 in 8e80bda

	useEffect(() => {
	if (!countryFromUrl || countryFromUrl === currentCountry) {
	return;
	}
	handleAddressChange(countryFromUrl, 'country');
	}, [countryFromUrl, handleAddressChange, currentCountry]);

Notice that currentCountry is also in a dependency list. So when autocomplete changes country it will trigger above useEffect and it will read countryFromUrl and set it to current country reverting the changes.

What changes do you think we should make in order to solve the problem?

We should remove currentCountry from dependency list, and I think we can also remove countryFromUrl === currentCountry condition which won't affect expected behavior. So at the end, this useEffect is triggered only if country in route is changed

What alternative solutions did you explore? (Optional)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - 'Country' not change if select it manually and then select another suggested address

What is the root cause of that problem?

When the user selects a country from the country list, we will set the selected country to route. But when the country is completed automatically by Google API, we don't reset the country in the route. So that the country in route will override the selected country

What changes do you think we should make in order to solve the problem?

When a country is changed automatically by Google API (clicking suggestion from address line 1), we should reset the route to settings/profile/personal-details/address

In here:

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 189 in 44bcf1c

onValueChange={handleAddressChange}

We should update like this

onValueChange={(value, key)=> {
                                if (countryFromUrl) {
                                    Navigation.navigate(ROUTES.SETTINGS_PERSONAL_DETAILS_ADDRESS)
                                }
                                handleAddressChange(value, key)
                            }}

As mentioned here #29382 (comment) We also remove the redundant call by removing currentCountry here

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 161 in 44bcf1c

}, [countryFromUrl, handleAddressChange, currentCountry]);

Result

Screen.Recording.2023-10-16.at.22.04.06.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0192336d38fb4edbd9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)