[HOLD for payment 2023-11-02] [$500] Chat - Reply in thread show on first thread message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697012817574599

Action Performed:

1. Click FAB button
2. Click Request money.
3. Input amount => Next
4. Select a workspace
5. Click request
6. Click request preview
7. Click. Pay elsewhere on header
8. Hover on paid message click reply in thread
9. Hover on first thread message, Observe that the reply in thread icon appears

Expected Result:

The reply in thread icon does not appears on first thread message

Actual Result:

The reply in thread icon appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-11.at.15.45.12.mov

Android: mWeb Chrome

Screen.Recording.2023-10-11.at.16.05.24.mov

iOS: Native

RPReplay_Final1697013670.MP4

iOS: mWeb Safari

RPReplay_Final1697013701.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-11.at.15.21.01.mov

Recording.4954.mp4

MacOS: Desktop

Screen.Recording.2023-10-11.at.16.15.51.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b28c57e1c51d2db4
• Upwork Job ID: 1712150594974400512
• Last Price Increase: 2023-10-18
• Automatic offers:
• namhihi237 | Contributor | 27269498
• namhihi237 | Reporter | 27269499

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b28c57e1c51d2db4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[kbecciv]

Proposal by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697012817574599

Proposal

Please re-state the problem that we are trying to solve in this issue.

The reply in the thread icon does not appear on the first thread message

What is the root cause of that problem?

We have the logic to show the reply icon in the thread here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 128 to 131 in d1ff84b

	const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID);
	const isReportPreviewAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW;
	const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionsUtils.isSplitBillAction(reportAction);
	return isCommentAction || isReportPreviewAction || isIOUAction;

We have only tested the first message for the report action which is isCommentAction here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 128 in d1ff84b

const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID);

But in case we hover on the first IOU message, it does check is first message.

What changes do you think we should make in order to solve the problem?

We should check isThreadFirstChat for the whole thing.

const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT
return (isCommentAction || isReportPreviewAction || isIOUAction) && !ReportUtils.isThreadFirstChat(reportAction, reportID);

What alternative solutions did you explore? (Optional)

N/A

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The reply in the thread icon does not appear on the first thread message

What is the root cause of that problem?

We didn't check isThreadFirstChat about isIOUAction .

What changes do you think we should make in order to solve the problem?

We need to add checking isThreadFirstChat about isIOUAction .

const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU &&
!ReportActionsUtils.isSplitBillAction(reportAction) && !ReportUtils.isThreadFirstChat(reportAction, reportID);

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 130 in f557852

const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionsUtils.isSplitBillAction(reportAction);

What alternative solutions did you explore? (Optional)

[bfitzexpensify]

Couple of proposals ready for review @eVoloshchak