[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report and focus on composer
3. Open settings->about->app download links
4. Right click on any download link and click copy
5. Start typing anything and observe that app writes everything in composer even though RHN is open

Expected Result:

App should not focus back on composer if RHN is open

Actual Result:

App focuses back on composer even if RHN is open on copy link from app download link in about settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native - not testable
• Android / Chrome - not testable
• iOS / native - not testable
• iOS / Safari - not testable
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.desktop.composer.refocus.on.open.RHN.mov

windows.chrome.composer.focus.copy.link.about.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696495147575079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7a9e4d7988e32e2
• Upwork Job ID: 1709947117056393216
• Last Price Increase: 2023-10-05
• Automatic offers:
• dukenv0307 | Contributor | 27123533
• dhanashree-sawant | Reporter | 27123535

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a7a9e4d7988e32e2

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[martin12345678900]

Can't reproduce :/

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App focuses back on composer even if RHN is open on copy link from app download link in about settings

What is the root cause of that problem?

In here, after copying the link, we're always refocusing on the composer, even in the case where another route is open.

What changes do you think we should make in order to solve the problem?

In there, we should check that the active route is the report route, if yes we trigger the refocusing. For example, we can do something like this

if (!Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(Navigation.getTopmostReportId()))) {
    return;
}

(This can be checked here or inside ReportActionComposeFocusManager.focus, where it will take effect for all attempts to focus the composers)

What alternative solutions did you explore? (Optional)

This might happen for other opened context menu as well, we should double check and fix the same for those places.
If we decide to add the check in ReportActionComposeFocusManager.focus then it will work for all places.

[chahedmoetaz]

Any updates?

[melvin-bot]

📣 @chahedmoetaz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>