[PAID] [HOLD for payment 2023-10-13] [$250] Distance - App crashes when clicking "Replace" while replacing images in IOU.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open FAB and select "Request Money" in Distance Mode.
2. Add start and end points, create a workspace, and split the bill.
3. Go to IOU, click on the map image, and select the three dots in the top right corner. From the dropdown, select "Replace".
4. The app crashes.

Expected Result:

The app should not crash when replacing images in IOU.

Actual Result:

App crashes when clicking "Replace" while replacing images in IOU.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-04.at.9.29.43.PM.mov

Recorder_05102023_072040.mp4

Screen.Recording.2023-10-04.at.9.17.26.PM.mov

Screen.Recording.2023-10-04.at.9.14.49.PM.mov

Screen.Recording.2023-10-04.at.9.03.24.PM.mov

Screen.Recording.2023-10-04.at.8.56.54.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696478163356909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01324cd349c7f43f8b
• Upwork Job ID: 1709905823974797312
• Last Price Increase: 2023-10-05

[gadhiyamanan]

Proposal



Please re-state the problem that we are trying to solve in this issue.


App crashes on click of "Replace"

What is the root cause of that problem?

We are using wrong route here

What changes do you think we should make in order to solve the problem?


use ROUTES.EDIT_REQUEST.getRoute instead of ROUTES.getEditRequestRoute



App/src/components/AttachmentModal.js

Line 351 in 1eae800

onModalHideCallbackRef.current = () => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.RECEIPT));

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01324cd349c7f43f8b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.