[HOLD for payment 2023-10-18] [$500] Two "Flag as offensive" list opens

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. hover on message and right click
3. select Flag as offensive
4. click on back button

Expected Result:

should hide Flag as offensive list

Actual Result:

Flag as offensive list appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-04.at.2.24.22.PM.1.mov

Screen.Recording.2023-10-04.at.2.17.48.PM.1.mov

Recording.472.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696409294638669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfd52163177c5b7e
• Upwork Job ID: 1709673665006915584
• Last Price Increase: 2023-10-04
• Automatic offers:
• gadhiyamanan | Contributor | 27048435
• gadhiyamanan | Reporter | 27048436

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bfd52163177c5b7e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[m-natarajan]

Proposal by @gadhiyamanan

Please re-state the problem that we are trying to solve in this issue.

two Flag as offensive list open

What is the root cause of that problem?

We are navigate to flag comment two times here and here

What changes do you think we should make in order to solve the problem?

add return after hideContextMenu and navigate to flag comment

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 374 to 376 in 56eda28

	if (closePopover) {
	hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID)));
	}

[ayazalavi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on context menu item Flag as offensive opens a popover but it is not getting closed.

What is the root cause of that problem?

There is redundant call to navigate method in onPress event of the menu item

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 373 to 379 in 6d86d5a

	onPress: (closePopover, {reportID, reportAction}) => {
	if (closePopover) {
	hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID)));
	}
	Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID));
	},

What changes do you think we should make in order to solve the problem?

We need to confirm why 2 times above callback is being called and if second callback is not necessary then remove it

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 378 in 6d86d5a

Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID));

or simply returning after hideContextMenu call will also fix the issue

What alternative solutions did you explore? (Optional)

N/A

[maxconnectAbhi]


# Proposal

Please re-state the problem that we are trying to solve in this issue

"Flag as offensive" list modal opens two times

What is the root cause of that problem?

Following callback is the root cause

onPress: (closePopover, {reportID, reportAction}) => { 
     if (closePopover) { 
         hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID))); 
     } 
  
     Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction.reportActionID)); 
 }, 

What changes do you think we should make in order to solve the problem?

In above callback we need to remove one Navigation call

What alternative solutions did you explore? (Optional)

NA

[burczu]

I've reviewed all the proposals and all of them define the root cause correctly but I think the best solution (and the first one) is the one from @gadhiyamanan - I believe here the return statement is just missing in the if block - we can compare it with similar implementations of onPress method for other context menu items in the ContextMenuActions.js - they are similar so I believe calling navigate twice is intended.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[gadhiyamanan]

@m-natarajan is from QA team and he posted solution from slack

cc: @burczu @francoisl

[burczu]

@gadhiyamanan Ahh... sorry, I didn't notice it! Updated!