[HOLD for payment 2023-10-12] [$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Click on FAB > Request Money > Manual tab
3. Enter '0' if not already there in the amount
4. Click on Next

Expected Result:

The gap between the error messages is consistent, just like on other pages, such as Home Address, Legal Name, Date of Birth, etc

Actual Result:

The gap is much larger than the gap between error message and CTA button on any other page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.4803.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c93d7659514ccde7
• Upwork Job ID: 1707802938882224128
• Last Price Increase: 2023-09-29
• Automatic offers:
• aman-atg | Contributor | 26975517
• aman-atg | Reporter | 26975520

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c93d7659514ccde7

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[kbecciv]

Proposal by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709

Proposal

Please re-state the problem that we are trying to solve in this issue.

The gap between error message and 'Next' button is much larger for Request Money's Manual Page

What is the root cause of that problem?

We are using styles.mt5 here which works for platforms where BigNumberPad component is visible but for other platforms this much gap is unnecessary. And FormHelpMessage itself has marginBottom values which further increases the gap between the error message and the button.

What changes do you think we should make in order to solve the problem?

We can define a variable like canUseTouchScreen and use it to determine which value to use for the top margin.

Example:

 
                {canUseTouchScreen ? (
                    <BigNumberPad
                      // ...other props
                    />
                ) : null}
                <Button
                    // ...other props
                    style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt2]}
                />

Here, I've used styles.mt2 but we can use any other value as well as per design team's suggestion.
With this, the total gap between will be 12px, considering styles.mt2 from the Button and styles.mb1 from the FormHelpMessage

What alternative solutions did you explore? (Optional)

We can use various margin spacing combinations for the FormHelpMessage and Button components, such as using styles.mb0 and styles.mt3 respectively when canUseTouchScreen is false.

However, changing FormHelpMessage's style will also have an effect when canUseTouchScreen is true and BigNumberPad is visible so it needs to be validated by the design team if we choose to do so.

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message have different space in some places

What is the root cause of that problem?

Due to extra styles passed as props, we are getting this error.

What changes do you think we should make in order to solve the problem?

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Lines 260 to 274 in 67d4a7a

	{DeviceCapabilities.canUseTouchScreen() ? (
	<BigNumberPad
	nativeID={NUM_PAD_VIEW_ID}
	numberPressed={updateAmountNumberPad}
	longPressHandlerStateChanged={updateLongPressHandlerState}
	/>
	) : null}
	<Button
	success
	medium={isExtraSmallScreenHeight}
	style={[styles.w100, styles.mt5]}
	onPress={submitAndNavigateToNextPage}
	pressOnEnter
	text={buttonText}
	/>

Just need to replace mt5 with mt3 like this

  <Button
                    success
                    medium={isExtraSmallScreenHeight}
                    style={[styles.w100, styles.mt2]}
                    onPress={submitAndNavigateToNextPage}
                    pressOnEnter
                    text={buttonText}
                />

no need to change it with respect to devices as there is already a condition based on DeviceCapabilities.canUseTouchScreen() on top

What alternative solutions did you explore? (Optional)

N/A

[allroundexperts]

@aman-atg's proposal looks good to me. I think we need to reduce the margin only if the number pad is not visible.

🎀 👀 🎀 C+ reviewed