[HOLD for payment 2023-10-10] [$250] App crashing when clicked send message from Fub menu quickly after sign in from google

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Logout from App
2. Sign in with google.
3. Click on fab menu "+" button and then click on send message.

Expected Result:

App is not crashing

Actual Result:

App is crashing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-29.at.5.12.23.PM.mov

Screen.Recording.2023-09-29.at.5.37.34.PM.mov

Recording.4798.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695988989758259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139365f545cd489dc
• Upwork Job ID: 1708418024558505984
• Last Price Increase: 2023-10-01
• Automatic offers:
• fedirjh | Contributor | 26964681
• ishpaul777 | Reporter | 26964683
• mkhutornyi | Contributor | 26964704

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Just a quick note - App crashes only when send message is clicked when LHN and Report loading skelaton is visible.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The App crashes when Send Message option in Fab menu is opened quickly.

What is the root cause of that problem?

The root cause of this issue is that the OpenApp command sends a report_0 having value null. This gets reflected in allReports variable here. This causes allReports[key].reportID to throw an error since allReports[key] is null.

What changes do you think we should make in order to solve the problem?

We should replace this with:

    return !_.isEmpty(allReports) && _.some(_.keys(allReports), (key) => allReports[key] && allReports[key].reportID);

What alternative solutions did you explore? (Optional)

We can also fix this on the backend and make sure that OpenApp command does not send a broken report like report_0: null.

Following is the CURL for this request:

curl 'http://localhost:8082/api?command=OpenReport' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryzC2HnBZtSQsLTojB' \
  -H 'Cookie: amp_session_id=1692799716207%20%7C%20a23f4ec2-f9f3-4b5a-8d33-f7c358a72f03; g_state={"i_l":0}' \
  -H 'Origin: http://localhost:8082' \
  -H 'Pragma: no-cache' \
  -H 'Referer: http://localhost:8082/r' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'Sec-GPC: 1' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Chromium";v="116", "Not)A;Brand";v="24", "Brave";v="116"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw $'------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="reportID"\r\n\r\nnull\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="emailList"\r\n\r\n\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="accountIDList"\r\n\r\n\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="parentReportActionID"\r\n\r\n0\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="clientLastReadTime"\r\n\r\n\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="appversion"\r\n\r\n1.3.75-0\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="apiRequestType"\r\n\r\nwrite\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="pusherSocketID"\r\n\r\n\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="shouldRetry"\r\n\r\ntrue\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="canCancel"\r\n\r\ntrue\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="authToken"\r\n\r\n148BAE65DD7CA61DE406AAF92281A3933ADF355C3E5BB82AEC78F42710EF969E57EF616CAB010B28D9160E5E020EA9F3D9D6DB586D6286DDA60119807F9E4B1435209B5F5ECA24157DD4151411DE8157CB5FCFCF556A06CCE95963AF89C53AB80D08E192EAD8FF298757B34421AD686EF539060F9EE5B24C4492BC11D9CB7A1A48D9FD987273D09322CA2947027E20464BED61D316C7559B8FF57850639DA6480084A76B8C9098F1F6576B588B1DCA4946D69F25B5E52163F0F15D3809E2564A244FF39D60A1BFF6550C9EAF56D9D00D7D38A4F384FBEE9A4AF88CBB886D31B275E0FC0EEE37501A945EBDFF6E5DDFD3AE1FCBAC11F420D8DF32A14A79E293BF25A3285C8D6F153FB2B50AA8971D858332CF39550E85E8F5B44B89C3ED5124726100D0F6760F14ED4CD1936073C9439688F77E4C2F12BAD796B50F64187C51C7B68EFE1C6EB520F3427D86DC6FAE298D3C3E862D8E95978DA63B23B1FC04C66F\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="referer"\r\n\r\necash\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="platform"\r\n\r\nweb\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="api_setCookie"\r\n\r\nfalse\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB\r\nContent-Disposition: form-data; name="email"\r\n\r\nallroundexperts@gmail.com\r\n------WebKitFormBoundaryzC2HnBZtSQsLTojB--\r\n' \
  --compressed

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when deep link Send message page after login

What is the root cause of that problem?

As soon as login, there's no reportID in route param.
And this function returns null string

App/src/pages/home/ReportScreen.js

Lines 138 to 140 in 5fd69da

	function getReportID(route) {
	return String(lodashGet(route, 'params.reportID', null));
	}

null string doesn't meet this condition:

App/src/pages/home/ReportScreen.js

Lines 244 to 246 in 5fd69da

	if (!reportIDFromPath) {
	return;
	}

So OpenReport api is called with null reportID

What changes do you think we should make in order to solve the problem?

Solution1: set fallback value to empty string (``)

    return String(lodashGet(route, 'params.reportID', ''));

Solution 2: As Solution 1 might return all reports if subscribe onyx with report_, so better to leave null string as is. So just update this condition:

        if (!reportIDFromPath || reportIDFromPath === 'null' || reportIDFromPath === '0') {

We can make util function isValidReportID(reportID) for this.

[mountiny]

@mkhutornyi Can you point out what change in staging aused this blocker as part of your proposal?

[mkhutornyi]

I confirmed that #26772 caused this.

[fedirjh]

@mkhutornyi The Second solution makes sense, can we also fix the crash inside ReportUtils.isReportDataReady?