[HOLD for payment 2023-11-22] [$500] Profile - Cannot enter address in personal details, address disappears after entering

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on Settings -> Profile
2. Click on Personal details and select Home address
3. At address line 1, enter any address (usually in Korea and Japan),
4. Select the corresponding address on the popup
5. Observe as the address disappears after selection and the message "This field is required."

Expected Result:

The address does not disappear after entering, and the message "This field is required."

Actual Result:

The address disappears after entering, and the message "This field is required."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

5338083306349188786.mp4

7097945649955358673.mp4

4489128905580805098.mp4

5827295511296995939.mp4

screen-capture.2.webm

4245390089819698170.mp4

1908843729046825860.mp4

Recording.4758.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thuyle04
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695454796208109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d58a9fe0eac5ad60
• Upwork Job ID: 1707737411849535488
• Last Price Increase: 2023-10-20

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d58a9fe0eac5ad60

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The core issue revolves around the inconsistency in displaying the proper street name and number in the user interface. Even if the Google Places API provides a premise and subpremise for specific addresses, the current system isn't adequately handling and displaying this data.

What is the root cause of that problem?

The root cause can be traced back to the original codebase not accounting for certain scenarios:

1. The original code doesn't recognize or handle the premise field from the Google Places API, leading to incomplete or inaccurate address representation.
2. The code lacks a mechanism to consider potential alternate values for the street number and street name. Some addresses may contain these details in fields other than the standard street_number and route.

App/src/components/AddressSearch/index.js

Line 147 in 5fd69da

const saveLocationDetails = (autocompleteData, details) => {

What changes do you think we should make in order to solve the problem?

The following changes, as observed in the updated code, were proposed to address the issue:

1. Introduce the capability to process additional field (premise) from the Google Places API.
2. Implement fallback logic for street number and street name using finalStreetNumber and finalStreetName to utilize values from potentialStreetNumber and potentialStreetName when standard fields are absent.
3. Refine the process of determining the city's name, emphasizing the hierarchy between locality, postalTown, sublocality and cityAutocompleteFallback to ensure the most accurate representation.

Changes that should be done in the code:

1. We should also extract premise from Google address details object and use it as street_number if that is empty.

2. We should get fallback street from GooglePlacesUtils.getPlaceAutocompleteTerms and use it when street is empty, we are already using fallbacks for country, state and city.

App/src/components/AddressSearch/index.js

Lines 196 to 200 in 5fd69da

	const {
	country: countryFallbackLongName = '',
	state: stateAutoCompleteFallback = '',
	city: cityAutocompleteFallback = '',
	} = GooglePlacesUtils.getPlaceAutocompleteTerms(autocompleteData.terms);

Sometimes city can be the same as street because if locality & postalTown is absent then it will use sublocality which can be the name of the street, so we should consider cityAutocompleteFallback before sublocality

3. The process to determine the city's name is refined.
   Previous: city: locality || postalTown || sublocality || cityAutocompleteFallback
   Updated: locality || postalTown || cityAutocompleteFallback || sublocality

[jjcoffee]

@Krishna2323 Thanks for your proposal! Please could you refrain from posting such long code snippets and focus only on smaller snippets that show your changes (with explanations).

[Krishna2323]

@jjcoffee, thanks for the info, I will keep this in mind before posting new proposals.