[$500] iOS - Send message - "You appear to be offline.'' message is shown twice in IOS in New Chat Page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login on the IOS app with a new account
2. go to settings > preferences > and check force offline
3. click on the + floating action button
4. click send message
5. observe the ''You appear to be offline'' message in the New Chat Page

Expected Result:

'You appear to be offline.'' message is shown once in IOS in New Chat Page

Actual Result:

''You appear to be offline.'' message is shown twice in IOS in New Chat Page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @rayane-djouah

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695728283307099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfe5272e5528fa4d
• Upwork Job ID: 1707065051587596288
• Last Price Increase: 2023-10-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bfe5272e5528fa4d

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[izarutskaya]

Proposal from @rayane-djouah

Please re-state the problem that we are trying to solve in this issue.

''You appear to be offline.'' message is shown twice in New Chat Page

What is the root cause of that problem?

the ScreenWrapper in NewChatPage component is showing a second offline message in addition to the existing one of the high level component.

What changes do you think we should make in order to solve the problem?

we should add shouldShowOfflineIndicator={false} for the ScreenWrapper in NewChatPage

App/src/pages/NewChatPage.js

Lines 171 to 177 in cfad43f

	<ScreenWrapper
	shouldEnableKeyboardAvoidingView={false}
	includeSafeAreaPaddingBottom={false}
	includePaddingTop={false}
	shouldEnableMaxHeight
	testID={NewChatPage.displayName}
	>

Result:
https://github.com/Expensify/App/assets/77965000/adae6aa1-1cad-4546-a197-d07dd119d2d8

What alternative solutions did you explore? (Optional)

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When offline, “You appear to be offline.'' message is shown twice in IOS in New Chat Selector Page. Only once it must be shown.

What is the root cause of that problem?

As shown here in the NewChatSelectorPage, the new chat selector page can either show NewChatPage or a tab with NewChatPage or WorkspaceNewRoomPage. Since NewChatPage and WorkspaceNewRoomPage are both showing Offline Indicator within their ScreenWrapper, the ScreenWrapper within NewChatSelectorPage will also duplicate the display of Offline Indicator. This is the root cause.

What changes do you think we should make in order to solve the problem?

To solve this problem, we can disable Offline Indicator for NewChatSelectorPage by setting shouldShowOfflineIndicator property to false in ScreenWrapper here as follows:

        <ScreenWrapper
            shouldEnableKeyboardAvoidingView={false}
            includeSafeAreaPaddingBottom={false}
            shouldEnableMaxHeight
+	    shouldShowOfflineIndicator={false}
            testID={NewChatSelectorPage.displayName}
        >

This will ensure that the duplicate Offline Indicator is not shown for both NewChatPage and WorkspaceNewRoomPage.

What alternative solutions did you explore? (Optional)

[rayane-d]

Updated Proposal

original proposal link

Please re-state the problem that we are trying to solve in this issue.

''You appear to be offline.'' message is shown twice in New Chat Page and New Room Page

What is the root cause of that problem?

the ScreenWrapper in NewChatPage component and the ScreenWrapper in WorkspaceNewRoomPage are showing a second offline message in addition to the existing one in the ScreenWrapper of the higher order component NewChatSelectorPage.

What changes do you think we should make in order to solve the problem?

we should set shouldShowOfflineIndicator property to false in the the ScreenWrapper in NewChatPage component and the ScreenWrapper in WorkspaceNewRoomPage

<ScreenWrapper
    shouldEnableKeyboardAvoidingView={false}
    includeSafeAreaPaddingBottom={false}
    includePaddingTop={false}
    shouldEnableMaxHeight
+    shouldShowOfflineIndicator={false}
    testID={NewChatPage.displayName}
>

<ScreenWrapper
    shouldEnableKeyboardAvoidingView={false}
    includeSafeAreaPaddingBottom={false}
    includePaddingTop={false}
    shouldEnablePickerAvoiding={false}
+    shouldShowOfflineIndicator={false}
    testID={WorkspaceNewRoomPage.displayName}
> 

What alternative solutions did you explore? (Optional)