[HOLD for payment 2023-10-23][$500] Web - Account Settings - Inappropriate error message when add Legal name in non-English alphabet

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Profile > Personal details > Legal name
2. Fill the Legal first name or Legal last name with non-English alphabet letters ( Cyrillic alphabet - Гоце Матески)

Expected Result:

Error message should be appropriate, for example - Please enter a name using Latin characters

Actual Result:

Inappropriate error message (Name can only include letters.) appears when User add Legal name in non-English alphabet

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6214634_20230926_023604.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0173b61987caa93a3d
• Upwork Job ID: 1706828987571515392
• Last Price Increase: 2023-09-27
• Automatic offers:
• ntdiary | Reviewer | 27031539
• hungvu193 | Contributor | 27031540

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Validation message showed "Name can only include letters" when user tried to update their name with Cyrillic alphabet characters.

What is the root cause of that problem?

We're currently validating our first name with alphabetic and latin character, in this case, we're using Cyrillic alphabet, which caused the issue.

App/src/libs/ValidationUtils.js

Lines 374 to 376 in 52c3f53

	function isValidLegalName(name) {
	return CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS.test(name);
	}

What changes do you think we should make in order to solve the problem?

We should change the error message to make it more meaning full:

App/src/languages/en.ts

Line 971 in 52c3f53

hasInvalidCharacter: 'Name can only include letters.',

App/src/languages/es.ts

Line 968 in 52c3f53

hasInvalidCharacter: 'El nombre sólo puede incluir letras.',

"hasInvalidCharacter": `Name can only include alphabetic and latin letters.` // or: Name can only include alphabetic and latin characters.

Also update the error message in Spanish as well

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0173b61987caa93a3d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[lncramer]

Hey there, ran into this issue on Upwork and would be happy to help out.

I might need a bit of clarification on the expected result here. I am assuming that Гоце Матески should still be considered invalid, but that the error message just needs to be clearer.

Proposal

If the issue is simply that the error message needs to be updated, then I would update the English and Spanish string values for hasInvalidCharacter as appropriate. I would also add/update any related tests.

[melvin-bot]

📣 @lncramer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ntdiary]

Please re-state the problem that we are trying to solve in this issue.

Hi, folks, please describe the problem in your own words, rather than just copying the title. : )

Additionally, @lncramer, I'm glad you're interested in this project. Please follow our contributor guidelines, which have detailed steps on how to get involved. : )