[HOLD for payment 2023-10-02] [$500] Web - Cursor Changes to Text Cursor Instead of Hand Cursor for Long Private Messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB and select "send message"
2. Add email and click on the header to access private notes
3. Select "My Notes" and add a long note
4. Go back and observe that the cursor has changed to a text cursor instead of a hand cursor

Expected Result:

The cursor should remain as a hand cursor for long private messages.

Actual Result:

The cursor changes to a text cursor for long private messages.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-09-19T222850.192.webm

Recording.4657.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695186909696099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01901da2d28d6828fb
• Upwork Job ID: 1704567536968368128
• Last Price Increase: 2023-09-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01901da2d28d6828fb

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor appears as text cursor instead of a pointer

What is the root cause of that problem?

The text being displayed has a cursor:auto styling coming from styles.chatItemMessage

https://github.com/Expensify/App/blob/94c07eabcf8f0c927b759956f24a72c28710186e/src/components/MenuItem.js#L259C52-L259C52

What changes do you think we should make in order to solve the problem?

Apply
cursor:poiner on the component displaying the priveate notes

<View style={[styles.chatItemMessage, cursor.cursorPointer]}>
    <RenderHTML html={getProcessedTitle} />
</View>

What alternative solutions did you explore? (Optional)

N/A

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor changes to a text cursor instead of the pointer cursor for private notes with long text.

What is the root cause of that problem?

In PrivateNotesViewPage, the MenuItemWithTopDescription which is used to display the note has the shouldRenderAsHTML prop set. This prop triggers a check for rendering the title in the MenuItem with this block of code:

<View style={styles.chatItemMessage}>
    <RenderHTML html={getProcessedTitle} />
</View>

styles.chatItemMessage contains ...cursor.cursorAuto which causes the I-beam cursor to be used for the text.

What changes do you think we should make in order to solve the problem?

Solution 1
Remove shouldRenderAsHTML prop from PrivateNotesViewPage.

Solution 2
Change the style in MenuItem from styles.chatItemMessage to a different style that uses cursorPointer.

What alternative solutions did you explore? (Optional)

None.