[$500] Web - Partial scroll to upper member on selecting member on invite member

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspace->members->invite
3. Scroll to bottom and click on any user
4. Again scroll to bottom and click any user, observe that now it scrolls half way above to first selected user

Expected Result:

App should either scroll back to top or should stop scroll above selected user to display selected user in top and user above it shouldn't be visible

Actual Result:

App scrolls half way to upper user making current selected user visible and above selected user half visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

partial.scroll.to.top.on.invite.member.mp4

Recording.4628.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695142928514269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4817e59f5fb70c4
• Upwork Job ID: 1704500577760190464
• Last Price Increase: 2023-09-27

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4817e59f5fb70c4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Partial scroll to upper member on selecting member on invite member

What is the root cause of that problem?

The value of viewOffset is higher than required.
Currently we are using getValueUsingPixelRatio(65, 100)

App/src/components/SelectionList/BaseSelectionList.js

Line 168 in d00a4d6

listRef.current.scrollToLocation({sectionIndex: adjustedSectionIndex, itemIndex, animated, viewOffset: variables.contentHeaderHeight});

App/src/styles/variables.ts

Line 15 in d00a4d6

contentHeaderHeight: getValueUsingPixelRatio(65, 100),

What changes do you think we should make in order to solve the problem?

Option 1

We need to adjust the value to getValueUsingPixelRatio(40, 100)

Option 2

We can scroll to the top instead of scrolling to specific element by setting sectionIndex to 0.

Result

fixed_demo.mp4