[HOLD for payment 2023-10-09] [Awaiting payment Oct 2 2023 / $500] Web - green dot appears even if task is deleted

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Click on + icon and select assign task
3. Enter title and assign task to you
4. Create task
5. Go to task thread and delete the task

Expected Result:

should not show green dot show if task is deleted

Actual Result:

green dot appears even if task is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.71-5
Reproducible in staging?: Y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-19.at.12.19.29.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695106297939429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01833b320ff7bd97a7
• Upwork Job ID: 1704197379523981312
• Last Price Increase: 2023-09-19
• Automatic offers:
• paultsimura | Contributor | 26790441
• gadhiyamanan | Reporter | 26790444

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01833b320ff7bd97a7

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The green dot is displayed in LHN for deleted task

What is the root cause of that problem?

Here we check for the optionItem.isArchivedRoom to check if the task is closed. The archival logic was removed now.

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 104 to 108 in f2282b2

	const shouldShowGreenDotIndicator =
	!hasBrickError &&
	(optionItem.isUnreadWithMention ||
	ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
	(optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

What changes do you think we should make in order to solve the problem?

We need to check for optionItem.isOpenTaskReport instead:

    const shouldShowGreenDotIndicator =
        !hasBrickError &&
        (optionItem.isUnreadWithMention ||
            ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
-           (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom))
+           (optionItem.isOpenTaskReport && optionItem.isTaskAssignee));

Add in SidebarUtils:

    if (result.isTaskReport) {
+       result.isOpenTaskReport = ReportUtils.isOpenTaskReport(report);
-       result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report);
        result.isTaskAssignee = ReportUtils.isReportManager(report);
    }

App/src/libs/SidebarUtils.js

Lines 268 to 271 in f6efb26

	if (result.isTaskReport) {
	result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report);
	result.isTaskAssignee = ReportUtils.isReportManager(report);
	}

Result:

https://www.loom.com/share/4e2f44055ded410ea5dfe9bef3368db8?sid=1c7304e3-39be-47b6-8685-2b6bd517ce21

What alternative solutions did you explore? (Optional)

[abzokhattab]

Proposal

The green dot is displayed in LHN for deleted task

What is the root cause of that problem?

we are not checking if the task is canceled in the green flag assignment

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 104 to 109 in 0603fe1

	const shouldShowGreenDotIndicator =
	!hasBrickError &&
	(optionItem.isUnreadWithMention ||
	ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
	(optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

What changes do you think we should make in order to solve the problem?

we should check if the task is not cancelled as well

    const shouldShowGreenDotIndicator =
        !hasBrickError &&
        (optionItem.isUnreadWithMention ||
            ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
            (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isCanceledTaskReport && !optionItem.isArchivedRoom));

and of course add the isCanceledTaskReport object to the SideBarUtils.js in line 268 to enable the OptionRowLHN to access it

    if (result.isTaskReport) {
        result.isCompletedTaskReport = ReportUtils.isCompletedTaskReport(report);
        result.isCanceledTaskReport = ReportUtils.isCanceledTaskReport(report);
        result.isTaskAssignee = ReportUtils.isReportManager(report);
    }

POC:

[rojiphil]

Not able to reproduce in latest main - v1.3.71-11

[paultsimura]

Still reproducible on 1.3.71-13

[rojiphil]

Oops! Sorry @paultsimura. I can also reproduce it. Thanks for the verification.