[HOLD for payment 2023-10-09] 🟡 [$500] [Distance] - Hide the map scale control on Android

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open request money
2. Change the tab to distance
3. Select a start or finish distance

Expected Result:

The map should show the scale control as in the android app or it should be removed from the android too

Actual Result:

The scale control is hidden on the map of the web and mweb

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694616305506719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c8a9994720dfe80
• Upwork Job ID: 1703426646592622592
• Last Price Increase: 2023-09-17
• Automatic offers:
• ZhenjaHorbach | Contributor | 26813126
• jo-ui | Reporter | 26813129

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c8a9994720dfe80

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

ScaleControl doesn't show up in browsers

What is the root cause of that problem?

We don't pass ScaleControl component in MapView.web

What changes do you think we should make in order to solve the problem?

We can add <ScaleControl /> for our MapView.web

Which we can get from 'react-map-gl' library

We just need to add <ScaleControl/> inside <Map></Map>

App/src/components/MapView/MapView.web.tsx

Lines 67 to 90 in c77814f

	<Map
	ref={setRef}
	mapboxAccessToken={accessToken}
	initialViewState={{
	longitude: initialState.location[0],
	latitude: initialState.location[1],
	zoom: initialState.zoom,
	}}
	mapStyle={styleURL}
	>
	{waypoints?.map(({coordinate, markerComponent, id}) => {
	const MarkerComponent = markerComponent;
	return (
	<Marker
	key={id}
	longitude={coordinate[0]}
	latitude={coordinate[1]}
	>
	<MarkerComponent />
	</Marker>
	);
	})}
	{directionCoordinates && <Direction coordinates={directionCoordinates} />}
	</Map>

<ScaleControl position='top-left'/>

Also we can use unit props to set which units of measurement to use (If it's necessary).

What alternative solutions did you explore? (Optional)

We can remove ScaleControl from mobile applications

We need to pass scaleBarEnabled={false} for <Mapbox.MapView/>

App/src/components/MapView/MapView.tsx

Lines 66 to 75 in c77814f

	<Mapbox.MapView
	style={{flex: 1}}
	styleURL={styleURL}
	onMapIdle={setMapIdle}
	pitchEnabled={pitchEnabled}
	attributionPosition={{...styles.r2, ...styles.b2}}
	logoPosition={{...styles.l2, ...styles.b2}}
	// eslint-disable-next-line
	{...responder.panHandlers}
	>

[desirekaleba]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem we are trying to solve is the absence of a scale control on the Mapbox map displayed within the MapView component in a React Native application using the react-map-gl library. A scale control is a useful feature for users to understand the map's scale and distance between points, enhancing the user experience and providing valuable geographical context.

What is the root cause of that problem?

The root cause of this problem is that the ScaleControl component was not integrated into the existing codebase for the MapView component. The absence of this component is the reason why the scale control is missing from the map.

What changes do you think we should make in order to solve the problem?

To solve this problem, we propose the following changes:

1. Import the ScaleControl component from the react-map-gl library at the beginning of the MapView component file.
2. Insert the ScaleControl component within the Map component, allowing it to be displayed on the map.
3. Customize the appearance of the scale control by setting the maxWidth, unit, and the position props according to the desired design and unit preference.

These changes will add a scale control to the Mapbox map within the MapView component under src/components/MapView/MapView.web.tsx

What alternative solutions did you explore? (Optional)

N/A