[HOLD for payment 2023-09-29] [$500] Web - Skeleton loader has incorrect spacing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any report, wait for it to load and make sure the skeleton loader is in view.

Expected Result:

There should be 12px of margin between the fake avatar circle and the fake message lines to the right of it.

Actual Result:

Currently there is only 8px of margin between the fake avatar and the fake message lines.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694439750361219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100b93c103be50626
• Upwork Job ID: 1702032405100154880
• Last Price Increase: 2023-09-13
• Automatic offers:
• dukenv0307 | Contributor | 26722896

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loader has incorrect spacing

What is the root cause of that problem?

The circle has a center at coordinates (40;26) and a radius of 20

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 31 in 2ed276b

	<Circle
	cx="40"
	cy="26"
	r="20"

and the line has an abscissa of 67

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Line 34 in 2ed276b

x="67"

So the current spacing between the fake avatar and the line is 67 - (40 + 20) = 7px

What changes do you think we should make in order to solve the problem?

To make the spacing between the fake avatar and the line is 12px, we should change all x properties of the line to 40 + 20 +12 = 72

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Line 34 in 2ed276b

x="67"

What alternative solutions did you explore? (Optional)

NA

Result

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There should be a 12px of margin between the fake avatar circle and the fake message lines to the right of it.

What is the root cause of that problem?

We use SkeletonViewLines component to show the Skeleton loader.

In this component, we use Circle for the fake avatar and Rect for the fake message.

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 38 in 6c6b3ad

	<Circle
	cx="40"
	cy="26"
	r="20"
	/>
	<Rect
	x="67"
	y="11"
	width="20%"
	height="8"
	/>

Can see the distance of Circle and Rect = 67 - (40 + 20) = 7 px

What changes do you think we should make in order to solve the problem?

We need to update the coordinates of the upper left corner to 72 (40 + 20 + 12)

 <Rect
    x="72"

What alternative solutions did you explore? (Optional)

N/A

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

BUG: Skeleton loader has incorrect spacing

What is the root cause of that problem?

The four SVG Rect beside the avatar have x = 67 as absolute x value, but this value is incorrect.
The correct value should be (avatar width + avatar margin left + avatar margin right) = 40 + 20 + 12 = 72.

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 38 in 0805f72

	<Circle
	cx="40"
	cy="26"
	r="20"
	/>
	<Rect
	x="67"
	y="11"
	width="20%"
	height="8"
	/>

What changes do you think we should make in order to solve the problem?

Replace The four SVG Rect x = 72 instead of 67.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100b93c103be50626

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.