[HOLD for payment 2023-10-05] [$500] Green Dot is Shown in the LHN but there is no Button to settle

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new workspace
2. Request money and select the newly created workspace
3. Delete the workspace
4. Click on the requested money and notice no settle button there
5. Notice that there is a Green dot on the LHN

Expected Result:

No green dot on the LHN if there is no settle button

Actual Result:

There is a green dot.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T149.Greendot-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694609404430979

View all open jobs on GitHub

Recording.1585.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01537b6caa270fb519
• Upwork Job ID: 1701955779855437824
• Last Price Increase: 2023-09-13
• Automatic offers:
• 0xmiroslav | Reviewer | 26769100
• hungvu193 | Contributor | 26769104
• daveSeife | Reporter | 26769113

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01537b6caa270fb519

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green Dot is Shown in the LHN but there is no Button to settle

What is the root cause of that problem?

We will hide the SettleButton when the request is canceled, but we didn't implement it for green dot.

What changes do you think we should make in order to solve the problem?

We should change this condition here:

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 105 to 109 in 6c6b3ad

	const shouldShowGreenDotIndicator =
	!hasBrickError &&
	(optionItem.isUnreadWithMention ||
	ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
	(optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

to

const isParentArchivedRoom =  ReportUtils.isArchivedRoom(ReportUtils.getReport(optionItem.parentReportID))
 const shouldShowGreenDotIndicator =
        !hasBrickError &&
        (optionItem.isUnreadWithMention ||
            (ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) && !isParentArchivedRoom) ||
            (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

What alternative solutions did you explore? (Optional)

Update the logic of isWaitingForIOUActionFromCurrentUser function, if the parent report is archived, then we should return false.

[0xmiroslav]

@hungvu193 thanks for the proposal.

We will hide the SettleButton when the request is canceled

Do you have permalink where this logic is added?

[hungvu193]

@hungvu193 thanks for the proposal.

We will hide the SettleButton when the request is canceled

Do you have permalink where this logic is added?

I think here's is it: #27212