[HOLD for payment 2023-09-29] [$500] Request money - Scan - When the receipt scan fails, the requested user is prompted to "Enter an amount."

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1- Using userA Request money -> scan random image
2- select UserB
3- wait till the scan fails
4- Login to UserB
5- click on the requested money from user A

Expected Result:

"Enter an amount." should not be prompted to userB

Actual Result:

"Enter an amount." is prompted to userB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.69-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Enter-Amount.mp4

Recording.6223.mp4

Expensify/Expensify Issue URL:

Issue reported by: @hichamcc

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693996797234579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba12fc29f8de1dec
• Upwork Job ID: 1701928878419435520
• Last Price Increase: 2023-09-13

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the receipt scan fails, the requested user is prompted to "Enter an amount."

What is the root cause of that problem?

we show the error for all user regardless of user can edit the request or not.

What changes do you think we should make in order to solve the problem?

we need to show the error based on both canEdit and hasErrors
by edit it once here or where hasErrors is used.

App/src/components/ReportActionItem/MoneyRequestView.js

Line 92 in 6b1a667

hasErrors = TransactionUtils.hasMissingSmartscanFields(transaction);

What alternative solutions did you explore? (Optional)

we can keep the error visible for the requested user and conditionally change the format of it, eg: failed to scan amont!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba12fc29f8de1dec

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When receipt scan failed, both author and recipient see the "Enter amount" error.

What is the root cause of that problem?

The error is shown based on hasErrors && transactionAmount === 0 only, without checking the authorship.

What changes do you think we should make in order to solve the problem?

Based on the desired behavior, there are several options:

1. Only add checks of canEdit in these 2 places to make it look like subtitle={hasErrors && transactionAmount === 0 && canEdit ? translate('common.error.enterAmount') : ''}:

App/src/components/ReportActionItem/MoneyRequestView.js

Line 128 in 137c3a2

subtitle={hasErrors && transactionAmount === 0 ? translate('common.error.enterAmount') : ''}

App/src/components/ReportActionItem/MoneyRequestView.js

Line 164 in 137c3a2

subtitle={hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

2. I would recommend: adding a dedicated copies that would be shown to the recipient of the request in case of the scan failure. The logic of determining the copy would be the same, based on canEdit. It just would be more informative to the user.

What alternative solutions did you explore? (Optional)

[mallenexpensify]

Was able to reproduce, Hoping/assuming it can be external, @allroundexperts can you review the proposals above plz?