[HOLD for payment 2023-10-18] [$1000] Desktop - RBR - Deleted error notifications reappear after reloading

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Preconditions:
PDF for the test https://drive.google.com/file/d/1iOhC-C5CFh6x0W_a5ByTbKX8vW6tLTGW/view?usp=sharing

1. Open a New Expensify app
2. Log in with any account
3. Navigate to any report
4. Add a corrupted PDF file as an attachment using the link.
5. Remove the error notification that appears.
6. Refresh the application (CMD+R) or page

Expected Result:

Deleted error notifications should not reappear after a page refresh or reloading the app

Actual Result:

Deleted error notifications reappear after refreshing the page or reloading the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.68-15

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6198416_Recording__267.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0109ee3a6201dbf246
• Upwork Job ID: 1702260302620733440
• Last Price Increase: 2023-10-02
• Automatic offers:
• situchan | Reviewer | 27017995
• shubham1206agra | Contributor | 27017996

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0109ee3a6201dbf246

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[programmerkenzi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop, Web, iOS (Safari/Chrome), Android/Chrome - RBR - Deleted error notifications reappear after reloading

What is the root cause of that problem?

The root cause of this problem appears to be related to how the clearReportActionErrors function handles the deletion of error notifications and the associated report actions. The existing code may not correctly update the state or store data, leading to the reappearance of error notifications upon reloading the application. This issue is specifically observed in the src/libs/actions/ReportActions.js file.

What changes do you think we should make in order to solve the problem?

To address the issue of deleted error notifications reappearing after reloading in the Desktop application, I propose the following changes to the clearReportActionErrors function:

src/libs/actions/ReportActions.js

Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`, {
 [reportAction.reportActionID]: false,
});

This code snippet effectively replaces null with false to remove the association of the error with the report action, ensuring that deleted error notifications do not reappear after a reload.

Please review and let me know if any further information or changes are needed.

[melvin-bot]

📣 @programmerkenzi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[programmerkenzi]

Contributor details
Your Expensify account email: contact@kenzichen.com
Upwork Profile Link: https://www.upwork.com/fl/kenzichen