[HOLD for payment 2023-10-02] [$500] Web - Workspace name isn't shown in Share code/QR page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings -> workspace -> new workspace
2. Now a new workspace should be created with a name
3. Now go to newly created workspace chat head (on LHN) -> click details page -> share code
4. Notice under the QR, 'workspace' is written.
   Note : on #admin or #announce channel, proper workspace name is shown in QR. So it's inconsistent.

Expected Result:

QR should show the corresponding workspace's name. Not a static ' Workspace' text.

Actual Result:

Workspace name isn't shown in Share code/QR page in workspace's detail page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.68.12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-09.at.4.25.33.PM.mov

Recording.4415.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694256753873399

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dff2ccf739ae6892

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace name is not shown in QRCode of policy expense chat

What is the root cause of that problem?

For the policy expense chat report, report name is empty string. So this here shows empty string for workspace name.

App/src/pages/ShareCodePage.js

Line 68 in e25a27f

title={isReport ? this.props.report.reportName : this.props.currentUserPersonalDetails.displayName}

What changes do you think we should make in order to solve the problem?

We should change title to

title={isReport ? ReportUtils.getReportName(this.props.report) : this.props.currentUserPersonalDetails.displayName}
                            

here

App/src/pages/ShareCodePage.js

Line 68 in e25a27f

title={isReport ? this.props.report.reportName : this.props.currentUserPersonalDetails.displayName}

We can use a separate variable for title similar to subtitle for better clarity.

What alternative solutions did you explore? (Optional)

[0xmiroslav]

@c3024's proposal looks good to me.
🎀 👀 🎀 C+ reviewed