[HOLD for payment 2023-10-30] [$500] Web - Right click popup is stuck on search page open

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Right click on any message to open popup
4. Click on 'Add reaction' in popup
5. Again right click on same message to again open popup
6. Click CTRL+K/ CMD+K and observe that popup is stuck and displayed along with search page

Expected Result:

App should close the right click popup before opening search page

Actual Result:

App does not close right click popup before opening search page if we follow specified steps

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.68.12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

right.click.popup.not.dismissed.on.search.page.open.mp4

Recording.4409.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694190244716599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012411f85dfeed7435
• Upwork Job ID: 1701568949405835264
• Last Price Increase: 2023-10-03
• Automatic offers:
• mollfpr | Reviewer | 27108241
• tsa321 | Contributor | 27108242
• dhanashree-sawant | Reporter | 27108243

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012411f85dfeed7435

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[nahid633]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Right click popup is stuck on search page open

What is the root cause of that problem?

in PopoverWithMeasuredContent there is not click outside function.Therefore, whenever you click outside it stays there.

What changes do you think we should make in order to solve the problem?

so basically we need to hideModal when there is some action outside.this popover uses PopoverWithMeasuredContent
by adding onPressOut={this.hideContextMenu} it will solve the problem
in src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

What alternative solutions did you explore? (Optional)

we can add.
onPressOut={hideModal} to ReactNativeModal for all modals use ReactNativeModal in src/components/Modal/BaseModal.js

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If the context menu on ReportItem was opened after the EmojiPicker (or FAB), the cmd+k (open search) doesn't close the context menu modal.

What is the root cause of that problem?

While opening the context menu when the EmojiPicker is open, we have a race condition:

1. The ContextMenu opens
2. The EmojiPicker / FAB closes

Why?
In PopoverProvider, we have a listener for the contextmenu event (right-click) that should close the active popover. If you right-click somewhere outside the ReportActionItem, this listener works correctly.

App/src/components/PopoverProvider/index.js

Lines 50 to 61 in 23f3b49

	React.useEffect(() => {
	const listener = (e) => {
	if (!activePopoverRef.current || !activePopoverRef.current.ref || !activePopoverRef.current.ref.current || activePopoverRef.current.ref.current.contains(e.target)) {
	return;
	}
	closePopover();
	};
	document.addEventListener('contextmenu', listener);
	return () => {
	document.removeEventListener('contextmenu', listener);
	};
	}, [closePopover]);

However, in the PressableWithSecondaryInteraction we call e.stopPropagation() on the contextmenu event, which prevents the listener from being executed.

App/src/components/PressableWithSecondaryInteraction/index.js

Lines 56 to 59 in 4f02074

	e.stopPropagation();
	if (this.props.preventDefaultContextMenu) {
	e.preventDefault();
	}

What changes do you think we should make in order to solve the problem?

Since right-click interaction with PressableWithSecondaryInteraction is the only place where we call e.stopPropagation() on the contextmenu event, I recommend the following:

1. Along with stopping propagation of the contextmenu event, fire a custom event:

+       document.dispatchEvent(new CustomEvent("secondaryinteractioncontextmenu"));
        e.stopPropagation();
        if (this.props.preventDefaultContextMenu) {
            e.preventDefault();
        }

2. In PopoverContextProvider, attach the listener of the contextmenu event to our custom event as well:

    React.useEffect(() => {
        const listener = (e) => {
            if (!activePopoverRef.current || !activePopoverRef.current.ref || !activePopoverRef.current.ref.current || activePopoverRef.current.ref.current.contains(e.target)) {
                return;
            }
            closePopover();
        };
        document.addEventListener('contextmenu', listener);
+       document.addEventListener('secondaryinteractioncontextmenu', listener);
        return () => {
            document.removeEventListener('contextmenu', listener);
+           document.removeEventListener('secondaryinteractioncontextmenu', listener);
        };
    }, [closePopover]);

• This will ensure the contextmenu event is not bubbling up (as opposed to my previous suggestion to remove the e.stopPropagation) while the same listener will still be executed.
• Such approach fixes the modal issue with right-click once and for all places where a custom context menu is opened with a right-click.

custom-context-menu-event.mp4

What alternative solutions did you explore? (Optional)