[$500] Distance - Despite receiving the validation message "Please select unique waypoints," the system allows the user to proceed with the distance request

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the "+" icon.
2. Select "Request money" and then chose "distance."
3. Select the starting point and click "Add stop" until the button became disabled
4. Add a stop address.
5. Now add finishing points.
6. Attempted to send the request.

Expected Result:

After receiving the validation message "Please select unique waypoints," the user should not be able to proceed further with the request

Actual Result:

Despite the validation message, the system still allows the user to send the distance request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.67-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-09-05-at-104820-pm_vr8rIjME.mp4

Recording.1504.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693936855288019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015f75e3daaf63f614
• Upwork Job ID: 1701329084817547264
• Last Price Increase: 2023-09-11

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Despite receiving the validation message "Please select unique waypoints," the system allows the user to proceed with the distance request

What is the root cause of that problem?

We only disable the next button if we don't select two different waypoints.

App/src/components/DistanceRequest.js

Line 266 in 6b1a667

isDisabled={_.size(validatedWaypoints) < 2}

What changes do you think we should make in order to solve the problem?

We should also disable the next button if we have the route error

const transactionRouteError = ErrorUtils.getLatestErrorField(transaction, 'route');

<Button
    success
    style={[styles.w100, styles.mb4, styles.ph4, styles.flexShrink0]}
    onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
    isDisabled={_.size(validatedWaypoints) < 2 || !_.isEmpty(transactionRouteError)}
    text={translate('common.next')}
/>

App/src/components/DistanceRequest.js

Line 266 in 6b1a667

isDisabled={_.size(validatedWaypoints) < 2}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015f75e3daaf63f614

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[ZhenjaHorbach]

This is the second similar bug
Maybe we should disable the button in case of any error?

#27099 (comment)