[HOLD for payment 2023-10-02] [$500] Offline deleted workspace allows to open reimburse page and also allow to open and save rate page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Switch off the internet
3. Open settings->workspaces->any workspace->reimbursements and copy the URL
4. Delete the workspace opened in step 3
5. Open settings->workspaces and observe that by default we are not allowed to open deleted workspace
6. Paste and send the URL in any chat
7. Click on the URL in the chat and observe that it opens the deleted workspace reimbursement page
8. Click on rate tab and change the value for rate and save, observe that app does not provide any error

Expected Result:

App should not allow to open reimburse and rate page after workspace is deleted

Actual Result:

App allows to open reimburse and rate page and also does not provide error on save after workspace is deleted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20230908_005547.mp4

offline.deleted.workspaces.allows.to.open.reimburse.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693303155795799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120ee75107e7b68ee
• Upwork Job ID: 1701274596529786880
• Last Price Increase: 2023-09-11
• Automatic offers:
• 0xmiroslav | Reviewer | 26745200
• DylanDylann | Contributor | 26745201
• dhanashree-sawant | Reporter | 26745202

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0120ee75107e7b68ee

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline deleted workspace allows to open reimbure page and also allow to open and save rate page

What is the root cause of that problem?

In here, we only display not found page if the policy is empty or the current user is not admin

App/src/pages/workspace/WorkspacePageWithSections.js

Line 108 in 00ad8cf

shouldShow={_.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy)}

But when we delete workspace offline the policy still exist with pending Action is delete

What changes do you think we should make in order to solve the problem?

App/src/pages/workspace/WorkspacePageWithSections.js

Line 108 in 00ad8cf

shouldShow={_.isEmpty(policy) || !PolicyUtils.isPolicyAdmin(policy)}

In here, we add || policy.pendingAction === 'delete'

We also should do the same thing on all other workspace pages like: WorkspaceMembersPage, WorkspaceInvitePage, WorkspaceInviteMessagePage, WorkspaceInitialPage

What alternative solutions did you explore? (Optional)

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline deleted workspace allows to open reimbure page and also allow to open and save rate page

What is the root cause of that problem?

We're not restrcting the page or showing NotFoundPage.

What changes do you think we should make in order to solve the problem?

We need to update the following condition

App/src/pages/workspace/WorkspacePageWithSections.js

Line 109 in 5f9bb2e

subtitleKey={_.isEmpty(policy) ? undefined : 'workspace.common.notAuthorized'}

with the following condition as well.

    const isPendingActionDelete = lodashGet(policy,"pendingAction", CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE)

This way we know if the policy is an optimistic delete and we restrict user to move on further.

What alternative solutions did you explore? (Optional)

NA