[WAITING ON AIMANE TO COMPLETE CHECKLIST] [HOLD for payment 2023-10-02] [$500] Request money - Unread indicator doesn't appear when marking as unread in offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on + -> Request money -> Scan -> Choose file -> Continue
2. Reach "Receipt scan in progress…" page
3. Go offline
4. Chang date time
5. Mark the message as unread

Expected Result:

Unread indicator should appear

Actual Result:

Unread indicator doesn't appear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.67-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-05.At.22.44.04.mp4

Recording.1496.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dukenv0307

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693928604694079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01065ccca935909edf
• Upwork Job ID: 1701251311952404480
• Last Price Increase: 2023-09-18
• Automatic offers:
• aimane-chnaif | Reviewer | 26746297
• dukenv0307 | Contributor | 26746298
• dukenv0307 | Reporter | 26746300

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01065ccca935909edf

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[dukenv0307]

@izarutskaya Please help me to post my proposal in Slack to here. Thanks.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unread indicator doesn't appear when marking as unread in offline

What is the root cause of that problem?

When we edit the money request, we don't set lastReadTime and lastVisibleActionCreated for the transaction report in optimisticData. So unread doesn't work as expected

App/src/libs/actions/IOU.js

Line 994 in edab657

const optimisticData = [

What changes do you think we should make in order to solve the problem?

We should add optimisticData for transaction report in editMoneyRequest function

const currentTime = DateUtils.getDBTime();
    const optimisticReport = {
        lastReadTime: currentTime,
        lastVisibleActionCreated: currentTime
    };
    const optimisticData = [
        ...
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${transactionThread.reportID}`,
            value: optimisticReport,
        },
    ];

App/src/libs/actions/IOU.js

Line 994 in edab657

const optimisticData = [

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-09-05.at.22.50.53.mov