[HOLD for payment 2023-09-29] [$500] Chat - Emoji suggestion does not auto close after inserting eye emoji

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Type in ':eye' and colon in end to insert 👁️ emoji
4. Observe that suggestion does not close
5. Try the same for ':heart', ':joy' (colon in end of both examples) and observe that suggestion is closed automatically

Expected Result:

App should close the suggestion automatically once emoji is inserted as it does for emojis like 😂 (joy), ❤️ (heart)

Actual Result:

App does not close the suggestion automatically for 👁️ (eye) emoji

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.67-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

suggestion.not.autoclosed.eye.emoji.mp4

Recording.1495.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693927993330749

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e13c88c48491a5e5
• Upwork Job ID: 1701246242089250816
• Last Price Increase: 2023-09-11
• Automatic offers:
• jjcoffee | Reviewer | 26727033
• ahmedGaber93 | Contributor | 26727035
• dhanashree-sawant | Reporter | 26727037

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e13c88c48491a5e5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @abekkala (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji suggestion does not autoclose after inserting eye emoji

What is the root cause of that problem?

This because we only call calculateEmojiSuggestion after onSelectionChange and in this emoji case the selection not changed.

App/src/pages/home/report/ReportActionCompose/SuggestionEmoji.js

Lines 196 to 206 in 5c13816

	const onSelectionChange = useCallback(
	(e) => {
	/**
	* we pass here e.nativeEvent.selection.end directly to calculateEmojiSuggestion
	* because in other case calculateEmojiSuggestion will have an old calculation value
	* of suggestion instead of current one
	*/
	calculateEmojiSuggestion(e.nativeEvent.selection.end);
	},
	[calculateEmojiSuggestion],
	);

What changes do you think we should make in order to solve the problem?

We can do with several ways:
solution 1: if the comment replaces emoji and selection not change resetSuggestions

const updateComment = useCallback(() => {
  ...
  if (commentValue !== newComment) {
      const remainder = ComposerUtils.getCommonSuffixLength(commentRef.current, newComment);
      
      // if the comment replaces emoji and selection not change `resetSuggestions`
      if (selection.end === newComment.length - remainder){
          suggestionsRef.current.resetSuggestions();
      }
      ...
  }
// add selection to deps
}, [selection, ...]);         

solution 2: use setSelection directly in Composer props onSelectionChange={setSelection} and replace onSelectionChange function here with this useEffect

useEffect(() => {
    if (!suggestionsRef.current) {
        return;
    }
    suggestionsRef.current.onSelectionChange({nativeEvent : {selection}});
}, [suggestionsRef, selection, value]);

solution 3: use setSelection directly in Composer props like solution 2 and create onCommetValueChange in Sugguestions.js which has calculateEmojiSuggestion and calculateMentionSuggestion inside it, and use it useEffect when comment change

useEffect(() => {
    if (!suggestionsRef.current) {
        return;
    }
    suggestionsRef.current.onCommetValueChange(selection.end);
}, [suggestionsRef, selection, value]);

What alternative solutions did you explore? (Optional)

we can also move the logic to Suggestions.js or SuggestionEmoji and SuggestionMention with the same idea.

[jjcoffee]

@ahmedGaber93 Thanks for the proposal! Could you clarify a bit more as to why the selection doesn't change specifically for the eye emoji?