[HOLD for payment 2023-10-02] [$500] Web/Desktop - Request skeleton is shown grayed out instead the IOU details.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation with a request money.
2. Open the IOU details
3. Disable the internet connection on the device
4. Click Delete the request

Expected Result:

Verify the request has been deleted and the IOU preview in conversation has been updated (the message should be still grayed out)

Actual Result:

Request skeleton is shown grayed out instead the IOU details.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.65-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6190968_offline_delete.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bdce495f39748b20
• Upwork Job ID: 1700202090575839232
• Last Price Increase: 2023-09-08
• Automatic offers:
• 0xmiroslav | Reviewer | 26737448
• ginsuma | Contributor | 26737449

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request skeleton is shown grayed out instead the IOU details.

What is the root cause of that problem?

When we delete a money request, its transaction becomes empty, and then MoneyRequestSkeletonView shows.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 240 to 242 in db1a306

	{_.isEmpty(props.transaction) ? (
	<MoneyRequestSkeletonView />
	) : (

What changes do you think we should make in order to solve the problem?

We should add pendingAction={props.action.pendingAction} to OfflineWithFeedback here, and change the condition above to _.isEmpty(props.transaction) && !props.action.pendingAction.

The result is as below:

The amount becomes "$0.00", and the receipt image is lost because they need transaction data. I don't know if this is intentional.
If not, we can add previousTransaction to the optimistic data like we add previousMessage when deleting a report action.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bdce495f39748b20

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)