[HOLD for payment 2023-09-29] [$500] Web - 2 requests appears for few seconds on click of pay elsewhere button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to chat with userB
2. Click on + icon and select request money option
3. Enter amount and click on request button
4. From userB, click on pay elsewhere button

Expected Result:

It should not show 2 requests

Actual Result:

Requests appears for few seconds on click of pay elsewhere button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-05.at.12.28.39.PM.mov

Recording.4267.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693897414969169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ef8c662a1041de0d
• Upwork Job ID: 1699362909149663232
• Last Price Increase: 2023-09-13
• Automatic offers:
• s-alves10 | Contributor | 26670765
• gadhiyamanan | Reporter | 26670766

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[danieldoglas]

I don't think this is a deploy blocker. cc @mountiny @luacmartins, what do you think?

[mountiny]

@gadhiyamanan whats the 50units request in the LHN, that should not be there? How did it happen to show up?

I agree not a blocker

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2 requests appears for a few seconds on click pay-elsewhere button

What is the root cause of that problem?

This is a regression of this PR

When we pay the money request, payMoneyRequest function is called

In getPayMoneyRequestParams in this function, we get optimistic report preview action from ReportUtils.updateReportPreview

As you can see below, this function increases the childMoneyRequestCount by one as if we create a new money request

App/src/libs/ReportUtils.js

Line 2284 in b9c4832

childMoneyRequestCount: reportPreviewAction.childMoneyRequestCount + 1,

This is the root cause

What changes do you think we should make in order to solve the problem?

We should not increase the childMoneyRequestCount of report preview action for pay request.

1. Add the parameter named requestIncrease to the updateReportPreview function

function updateReportPreview(iouReport, reportPreviewAction, requestIncrease = 1, comment = '', transaction = undefined) {
    ... ...
        childMoneyRequestCount: reportPreviewAction.childMoneyRequestCount + requestIncrease,
}

2. Add this parameter to all the function call
   

   App/src/libs/actions/IOU.js

   Line 451 in b9c4832

   reportPreviewAction = ReportUtils.updateReportPreview(iouReport, reportPreviewAction, comment, optimisticTransaction);

        reportPreviewAction = ReportUtils.updateReportPreview(iouReport, reportPreviewAction, 1, comment, optimisticTransaction);

App/src/libs/actions/IOU.js

Line 1536 in b9c4832

const optimisticReportPreviewAction = ReportUtils.updateReportPreview(iouReport, ReportActionsUtils.getReportPreviewAction(chatReport.reportID, iouReport.reportID));

    const optimisticReportPreviewAction = ReportUtils.updateReportPreview(iouReport, ReportActionsUtils.getReportPreviewAction(chatReport.reportID, iouReport.reportID), 0);

This works as expected

Result

26767.mp4

What alternative solutions did you explore? (Optional)

We can remove the childMoneyRequestCount increasing code from the updateReportPreview function and do this action at the calling function

[gadhiyamanan]

@mountiny message appears even if only one money requested
https://github.com/Expensify/App/assets/54790231/7f3206ca-7d97-4176-bc7c-8efdd632b03d