[HOLD for payment 2023-09-29] [$500] Assign task - Colon (:) added to completed/reopened task messages when copy pasting

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. login to staging new dot
2. Go to any chat with a task
3. Copy the completed or reopened task message using the copy to clipboard icon
4. Paste the copied content in the composer and observe that a colon is added after completed or reopend when pasting

Expected Result:

Pasted content should be identical to copied content

Actual Result:

Pasted content has colon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.63-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

scrnli_8_25_2023_8-37-21.PM.mp4

Recording.1448.mp4

Expensify/Expensify Issue URL:

Issue reported by: @SofoniasN @oleksandr-pantsyr (reported first here)

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692985594255829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012810233ffe197834
• Upwork Job ID: 1699809589610123264
• Last Price Increase: 2023-09-07
• Automatic offers:
• Ollyws | Reviewer | 26589564
• sofoniasN | Reporter | 26589566
• oleksandr-pantsyr | Contributor | 26974844

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Colon (:) added to completed/reopened task messages when copy pasting

What is the root cause of that problem?

• Currently, the copied text is from the originalMessage that has the colon (:):

  App/src/pages/home/report/ContextMenu/ContextMenuActions.js

  Line 189 in f67bf9f

  const originalMessage = _.get(reportAction, 'originalMessage', {});

• But the displayed task action message is from: ${taskStatusText} ${taskReportName} that does not has the colon (:):
  

  App/src/components/ReportActionItem/TaskAction.js

  Lines 38 to 63 in f67bf9f

  	function TaskAction(props) {
  	const taskReportName = props.taskReport.reportName || '';
  	let taskStatusText = '';
  	switch (props.actionName) {
  	case CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED:
  	taskStatusText = props.translate('task.messages.completed');
  	break;
  	case CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED:
  	taskStatusText = props.translate('task.messages.canceled');
  	break;
  	case CONST.REPORT.ACTIONS.TYPE.TASKREOPENED:
  	taskStatusText = props.translate('task.messages.reopened');
  	break;
  	default:
  	taskStatusText = props.translate('task.task');
  	}
  	return (
  	<>
  	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
  	<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText} ${taskReportName}`}</Text>
  	</View>
  	</>
  	);
  	}

What changes do you think we should make in order to solve the problem?

• We can change the way to get the copied text to the same way that used to get the task action message like below:
• Create the getTaskReportActionMessage that is used for both <TaskAction /> and copiedText:

const getTaskReportMessage = (reportAction, translate) => {
    const taskReport = ReportUtils.getReport(reportAction.originalMessage.taskReportID.toString());
    const taskReportName = taskReport.reportName || '';

    let taskStatusText = '';
    switch (reportAction.actionName) {
        case CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED:
            taskStatusText = translate('task.messages.completed');
            break;
        case CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED:
            taskStatusText = translate('task.messages.canceled');
            break;
        case CONST.REPORT.ACTIONS.TYPE.TASKREOPENED:
            taskStatusText = translate('task.messages.reopened');
            break;
        default:
            taskStatusText = translate('task.task');
    }
    return `${taskStatusText} ${taskReportName}`;
};

What alternative solutions did you explore? (Optional)

• NA

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We use originalMessage to get the text to be copied here -

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 190 in b95c1dd

const messageHtml = isTaskAction ? lodashGet(originalMessage, 'html', '') : lodashGet(message, 'html', '');

and it looks like this

Observe it contains semicolon.
but while rendering it we display that separately(prop translation)

App/src/components/ReportActionItem/TaskAction.js

Lines 57 to 63 in b95c1dd

	<>
	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
	<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText} ${taskReportName}`}</Text>
	</View>
	</>
	);
	}

What changes do you think we should make in order to solve the problem?

There are two approaches that to solve this -

• We either change the TaskAction and add colon there

<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText}: ${taskReportName}`}</Text>

• We change the logic for copy action here -
  

  App/src/pages/home/report/ContextMenu/ContextMenuActions.js

  Line 190 in b95c1dd

  const messageHtml = isTaskAction ? lodashGet(originalMessage, 'html', '') : lodashGet(message, 'html', '');

For this we can create a new method in ReportActionUtils - getTaskActionText(actionName) it will return translated key for all the CONST.REPORT.ACTIONS.TYPE and then use it on above mentioned line while copying the text

What alternative solutions did you explore? (Optional)

[zanyrenney]

Yep, reproducible here - adding external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012810233ffe197834

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)