If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Run App on latest main branch (for now)
- Sign in with an account on the distance requests beta (or enable all betas)
- Click green plus, request money, distance
- Enter the same start and finish addresses
- Hit 'Next'
Expected Result:
There should be an error message saying "It looks like there's a duplicate waypoint, please edit and try again". It shouldn't be possible to navigate to the next step in the flow if there's an error message.
From the design doc:
When 2 or more waypoints are set we should validate them to ensure that each adjacent waypoint has a unique address, essentially removing redundant waypoints. For example you can drive from your home, to work, and back, but not from home to work, to work, and back. This also covers the case where there’s no route between the same start and finish waypoints. If validation fails we’ll set an error message under transaction.errorFields.waypoints and we won’t fetch the route.
When transaction.errorFields.route contains errors we’ll render an error message under the map view with a new component called ErrorMessageSection. It will contain this code from OfflineWithFeedback. The user will see the map with their waypoints but no route. The error message will instruct the user to edit the waypoints so that a route can be displayed.
Actual Result:
No error message
Workaround:
Yeah, don't do that
Platforms:
Which of our officially supported platforms is this issue occurring on?
All
Version Number: Unreleased
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693613331633999
View all open jobs on GitHub
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0161f64322541822f9
- Upwork Job ID: 1697765502650564608
- Last Price Increase: 2023-09-02
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
There should be an error message saying "It looks like there's a duplicate waypoint, please edit and try again". It shouldn't be possible to navigate to the next step in the flow if there's an error message.
From the design doc:
Actual Result:
No error message
Workaround:
Yeah, don't do that
Platforms:
Which of our officially supported platforms is this issue occurring on?
All
Version Number: Unreleased
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693613331633999
View all open jobs on GitHub
Upwork Automation - Do Not Edit