[HOLD for regression test] [$1000] Fix optimistic data for distance requests

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This issue is only present on the last main

This issue requires an immediate action. If you're posting a proposal, make sure you can open a PR within 6 hours of proposal approval

Action Performed:

1. Go to a workspace chat
2. Click "+" next to the text composer and click "Request money"
3. Click "Distance request" tab
4. Click "Start" and type any US address. Click any address suggestion.
5. Click "Finish" and and type any US address. Click any address suggestion. Make sure that the address is not the same address from Step 4.
6. Click "Next" and on the next page, click "Save"
7. Check that the data displayed is not correct (the amount is $0 for the distance request, for example)

This is a bug reported in this PR. Refer to that comment for screenshots

Expected Result:

The optimistic data should be the same as the distance request being created

Actual Result:

The optimistic data it not correct

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016ef448c9c160220d
• Upwork Job ID: 1697697328608083968
• Last Price Increase: 2023-09-01
• Automatic offers:
• jeet-dhandha | Contributor | 26458547

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016ef448c9c160220d

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @conorpendergrast (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)