Web - The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the website
2. Click the + icon from LHN
3. Click request money
4. Enter amount
5. Select Workspace from the list if there is no workspace create one before requesting a money
6. Confirm request money
7. Open the IOU report
8. Pay with "Pay Elsewhere"
9. Open edit request
10. Hover on the amount, description, merchant, and date
11. Observe the result

Expected Result:

The Cursor should display as disabled when hovering over the amount, description, merchant, or date for the paid request money.

Actual Result:

The Cursor displayed as enabled when hovering over the amount, description, merchant, or date for the paid request money.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-09-01.12_22_45.AM.mp4

Recording.4145.mp4

Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693516892936839

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.
Web - Workspace's badge is not appeared when hovering over it on thread

What is the root cause of that problem?

This is coming from this PR

What changes do you think we should make in order to solve the problem?

Option 1

We need to add disabled={isSettled && !canEdit} to all MenuItemWithTopDescription element

Option 2

We can only show the disabled cursor without greying the text, like we do with complete tasks.
shouldGreyOutWhenDisabled={false}

Option 3

If we don't want to grey out text and don't want to show the disabled cursor, we can pass focusable={canEdit}, so it doesn't add focus to task details if it has been paid.

Focus

Screen.Recording.2023-09-01.at.3.28.57.AM.mov

[luacmartins]

I don't think this is a blocker. There's no functionality impacted here and it's a small cursor UI thing.

[luacmartins]

IMO the way we have here is better, so I think we should do nothing, but I'll let @shawnborton chime in here.