[HOLD for payment 2023-09-27] [$500] mWeb - Workspace - "only visible to ..." Notifier overflows with long names

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to staging new dot
2. Go to workspaces and add a user with a long name as a member
3. Go to the new room created with that member
4. Observe the "only visible to ..." Notifier overflows

Expected Result:

Notifier shouldn't over flow

Actual Result:

Notifier overflows

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230906_120725_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @SofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692907694493579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b93c74d97d1a6605
• Upwork Job ID: 1701104424821248000
• Last Price Increase: 2023-09-11
• Automatic offers:
• jjcoffee | Reviewer | 26636298
• akinwale | Contributor | 26636302
• sofoniasN | Reporter | 26636304

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "only visible to ..." notice overflows with long names on small screens.

What is the root cause of that problem?

The numberOfLines prop is set to 1 for the DisplayNames component in ReportActionItem, so the text does not wrap.

App/src/pages/home/report/ReportActionItem.js

Lines 593 to 600 in 24d820a

	<DisplayNames
	fullTitle={ReportUtils.getWhisperDisplayNames(whisperedToAccountIDs)}
	displayNamesWithTooltips={displayNamesWithTooltips}
	tooltipEnabled
	numberOfLines={1}
	textStyles={[styles.chatItemMessageHeaderTimestamp]}
	shouldUseFullTitle={isWhisperOnlyVisibleByUser}
	/>

What changes do you think we should make in order to solve the problem?

Solution 1
Change the numberOfLines prop to 0 and add styles.flex1 to the textStyles prop so that the text wraps.

Also make the "Only visible to" text as a child of the DisplayNamesWithTooltip / DisplayNamesWithoutTooltip root component so that the text wraps properly. We will have to add a shouldShowOnlyVisible text prop with a default value of false which would conditionally show or hide this text. In the ReportActionItem component, set the prop to true.

<Text style={[styles.chatItemMessageHeaderTimestamp]}>
    {props.translate('reportActionContextMenu.onlyVisible')}
    &nbsp;
</Text>

Solution 2
Leave the numberOfLines prop as 1, and add styles.flex1 to the textStyles prop. This will allow the ellipsis to be displayed at the end of the text if it's longer than the screen width.

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@kbecciv it doesn't look likethe video in the OP is the one for this bug, can you double check?

Go to the new room created with that member

@SofoniasN, for the above, I'm not being sent to a room created with that member once I add them, is it the #announce or #admins room? Does it need to be a brand new user? Thx

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync