[C+ Checklist Needs Completion] [$500] Inconsistency bug: "Assign task" appear in modal of "+" actions button in thread of flagging

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a new conversation with User B
2. User A sends a message to User B
3. User B selects User A's "Flag Offensive" message -> choose any reason
4. User B replies in thread with Concierge
5. Click "+" button -> it shows "add attachment"
6. Click on any other chat and click back with the Concierge thread

Expected Result:

User should not be able to assign a task for Concierge.

Actual Result:

User can assign task in Concierge thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.58-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Kdb.mp4

Recording.6046.mp4

Expensify/Expensify Issue URL:

Issue reported by: @le Thi Thu Thuy

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692696877160359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197b4de7da68bcca2
• Upwork Job ID: 1697572011388342272
• Last Price Increase: 2023-09-08
• Automatic offers:
• jjcoffee | Reviewer | 26681642
• Pujan92 | Contributor | 26681644

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task option enabled for concierge thread chat

What is the root cause of that problem?

In the isExpensifyOnlyParticipantInReport function we are excluding the current user id but the filtered results length we are not considering which leads to the issue where the length of lodashGet(report, 'participantAccountIDs', []) gives 2 for this thread.

App/src/libs/ReportUtils.js

Lines 485 to 488 in 8650a9c

	function isExpensifyOnlyParticipantInReport(report) {
	const reportParticipants = _.without(lodashGet(report, 'participantAccountIDs', []), currentUserAccountID);
	return lodashGet(report, 'participantAccountIDs', []).length === 1 && _.some(reportParticipants, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID));
	}

What changes do you think we should make in order to solve the problem?

We can use reportParticipants.length in the condition to check the filtered participants array. With this, for the scenario where the user tries to reply in a thread for the flagged message it only considers the Concierge id.

[Charan-hs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency bug: "Assign task" appear in modal of "+" actions button in thread of flagging

What is the root cause of that problem?

Here,

App/src/libs/ReportUtils.js

Lines 483 to 486 in 0a7aabd

	function isExpensifyOnlyParticipantInReport(report) {
	const reportParticipants = _.without(lodashGet(report, 'participantAccountIDs', []), currentUserAccountID);
	return lodashGet(report, 'participantAccountIDs', []).length === 1 && _.some(reportParticipants, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID));
	}

We are checking the chat to determine if it's with the Concierge or participants. Basically, we check if it contains only one participantID and it's ConciergeID. In the current issue, it's happening the same when the user marks it as spam and clicks on the reply thread, The same condition occurs so it returns false.

What changes do you think we should make in order to solve the problem?

To Reslove this issue, we can check for Parent Report whether it's a chat with the concierge or participants.
To achieve the same
we can get parent report through this func

ReportUtils.getParentReport(report)

so we can do double check i.e once ReportUtils.isExpensifyOnlyParticipantInReport(report) or report.parentReportID returns true then we can check for the parent report i.e ReportUtils.isExpensifyOnlyParticipantInReport(ReportUtils.getParentReport(report))
or recursively we can check the Parent for Concierge or participants

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0197b4de7da68bcca2

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)