Skip to content

[HOLD for payment 2023-09-12] Design clean-up and consistency across expense reports and requests. #26138

Description

@JmillsExpensify

We've been making a lot of fast-and-loose changes to requests and reports as part of waves3-wave5, and as a result of adding merchant names for wave4, the end result isn't what we intended. Accordingly, this is a summary of what's broken and needs to be fixed.

  1. We're showing right carets for all report and request previews, when instead right carets should be removed from all request and report previews.

  2. Similarly, IOU reports are showing the merchant when they should instead be showing the description (because IOUs always have the same merchant, which is Request).

Image

  1. When a merchant name exists for an expense / request preview, we only show the merchant.

Image

  1. We're missing the X requests logic on report previews in the workspace chat. More specifically, when more than one request exists on the expense report, we replace the merchantName with X requests, where X is the number of requests on the report. We also show up to three receipt images in the report preview. If more than three receipts exist, then we show an overlay in the lower right corner of the right most receipt, +X. This overlay counts the number of additional receipts (e.g. receipts over 3) that exist on the report but can't be seen. Examples for completeness.
    Image

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignNewFeatureSomething to build that is a new item.

Type

No type

Fields

No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions