[HOLD #23088 Safari-only]Assign Task - Pasting a long text repeatedly when creating a task leads to trailing space which can't be edited

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat screen.
2. Click on "Assign Task."
3. Start pasting a long bunch of text repeatedly until you see some white space
4. Notice that the input starts replacing the text with white space
5. Click on "Next." You will probably notice that the title only shows the white space with three dots "..."
6. Click "Confirm Task."
7. Try to edit the title
8. It's almost impossible to delete the white space

Expected Result:

1. After pasting a long bunch of text repeatedly, the input field should handle the input correctly without introducing any trailing white space
2. When clicking on "Next," the title should display the entered text without any issues, and the text should be fully visible
3. When confirming the task, the title should be correctly saved without any unintended white space
4. When trying to edit the title, you should be able to modify the text without encountering any issues related to trailing white space
5. Deleting white space within the title field should be easy and responsive

Actual Result:

The long text when pasted repeatedly the trailing white space is generated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-19.at.18.17.13.mov

Recording.6025.mp4

Expensify/Expensify Issue URL:

Issue reported by: @brianmuks

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692464943500109

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign Task - Pasting a long text repeatedly when creating a task leads to trailing space which can't be edited

What is the root cause of that problem?

Value do not trim before saving for the next step
We don't trim the title and description before submitting them at

App/src/pages/tasks/NewTaskDetailsPage.js

Lines 66 to 68 in d09a1b6

	function onSubmit(values) {
	Task.setDetailsValue(values.taskTitle, values.taskDescription);
	Navigation.navigate(ROUTES.NEW_TASK);

What changes do you think we should make in order to solve the problem?

function onSubmit(values) {
        Task.setDetailsValue(values.taskTitle.trim(), values.taskDescription.trim());
        Navigation.navigate(ROUTES.NEW_TASK);
}

What alternative solutions did you explore? (Optional)

Trim all value in Form if it's a string at

App/src/components/Form.js

Lines 190 to 211 in d09a1b6

	const submit = useCallback(() => {
	// Return early if the form is already submitting to avoid duplicate submission
	if (props.formState.isLoading) {
	return;
	}
	// Touches all form inputs so we can validate the entire form
	_.each(inputRefs.current, (inputRef, inputID) => (touchedInputs.current[inputID] = true));
	// Validate form and return early if any errors are found
	if (!_.isEmpty(onValidate(inputValues))) {
	return;
	}
	// Do not submit form if network is offline and the form is not enabled when offline
	if (props.network.isOffline && !props.enabledWhenOffline) {
	return;
	}
	// Call submit handler
	onSubmit(inputValues);
	}, [props.formState, onSubmit, inputRefs, inputValues, onValidate, touchedInputs, props.network.isOffline, props.enabledWhenOffline]);

const submit = useCallback(() => {
        // Return early if the form is already submitting to avoid duplicate submission
        if (props.formState.isLoading) {
            return;
        }

        // Touches all form inputs so we can validate the entire form
        _.each(inputRefs.current, (inputRef, inputID) => (touchedInputs.current[inputID] = true));

        // Validate form and return early if any errors are found
        if (!_.isEmpty(onValidate(inputValues))) {
            return;
        }

        // Do not submit form if network is offline and the form is not enabled when offline
        if (props.network.isOffline && !props.enabledWhenOffline) {
            return;
        }
        const trimmedInputValues = {};
        _.each(inputValues, (inputValue, inputID) => {
            if (_.isString(inputValue)) {
                trimmedInputValues[inputID] = inputValue.trim();
            } else {
                trimmedInputValues[inputID] = inputValue;
            }
        })
        // Call submit handler
        onSubmit(trimmedInputValues);
    }, [props.formState, onSubmit, inputRefs, inputValues, onValidate, touchedInputs, props.network.isOffline, props.enabledWhenOffline]);

[suneox]

If you want to replace multiple spacing to avoid case 'a b' to 'a b' after trim we can apply a pattern inputValue.trim().replace(/\s\s+/g, ' ')

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!