[HOLD for payment 2023-09-11] [$1000] Web - Inconsistency bug: Incorrect Hand Cursor Displayed Throughout PDF Document in Attachment Viewer

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any conversation
2. Click the plus sign -> Add Attachment and select a pdf file, but do not send it yet
3. go to the PDF body within the previewer
4. Notice that the cursor behavior is correct in the previewer, with the hand cursor only displayed when hovering over hyperlinks or interactive elements
5. Send the attachment
6. Click the same attachment you sent to open it in the attachment viewer
7. In the attachment viewer, observe that the hand cursor is displayed throughout the entire PDF document, even in areas where there are no hyperlinks or interactive elements

Expected Result:

The hand cursor should only be displayed when hovering over hyperlinks or other interactive elements within the PDF document, both in the initial attachment previewer and the attachment viewer. When the mouse cursor is not over any interactive element, it should display the default cursor.

Actual Result:

The hand cursor is displayed throughout the entire PDF document in the attachment viewer, unlike the correct behavior observed in the initial attachment previewer.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-20

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

PDFcursor.mp4

Recording.1303.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Habben101

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691710745839059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0103449447ce220c8a
• Upwork Job ID: 1696237688336969728
• Last Price Increase: 2023-08-28
• Automatic offers:
• namhihi237 | Contributor | 26416157

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

display normal cursor and not clickable when hovering on white space

What is the root cause of that problem?

This issue has been fixed once in here
But after we refactor here it happened again.
Same as before, PDFView inside a PressableWithFeedback incase there's a onPress prop.

App/src/components/PDFView/index.js

Lines 283 to 287 in a03a21d

	render() {
	return this.props.onPress ? (
	<PressableWithoutFeedback
	onPress={this.props.onPress}
	style={[styles.flex1, styles.flexRow, styles.alignSelfStretch]}

Here we are passing onPress.

App/src/components/Attachments/AttachmentCarousel/index.js

Lines 137 to 142 in a03a21d

	<AttachmentView
	source={item.source}
	file={item.file}
	isAuthTokenRequired={item.isAuthTokenRequired}
	isFocused={activeSource === item.source}
	onPress={() => canUseTouchScreen && setShouldShowArrows(!shouldShowArrows)}

In the previous fix, we had set the default for onPress to undefined to prevent when using PDFView without passing the onPress prop. But here we always pass a boolean in.

What changes do you think we should make in order to solve the problem?

We should update in here:

onPress={ canUseTouchScreen ? () => setShouldShowArrows(!shouldShowArrows): undefined}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There's an inconsistency in the cursor behavior when viewing a PDF attachment. The hand cursor is displayed throughout the entire PDF document in the attachment viewer, even when not hovering over hyperlinks or interactive elements.

What is the root cause of that problem?

The cursor behavior for the PDF viewer in the attachment viewer is being influenced by global or inherited CSS styles, causing it to display the hand cursor throughout.

What changes do you think we should make in order to solve the problem?

To ensure consistent cursor behavior in the attachment viewer, we need to explicitly set the cursor style for the PDF viewer component.
Code Changes:
CSS Adjustments: Set the cursor style for the PDFView component to default to override any inherited styles that might be affecting the cursor behavior.

PDFView: {
    ...
    cursor: 'default',
},

Apply this style in:

App/src/styles/styles.js

Lines 2106 to 2117 in 8d5ae3a

	PDFView: {
	// `display: grid` is not supported in native platforms!
	// It's being used on Web/Desktop only to vertically center short PDFs,
	// while preventing the overflow of the top of long PDF files.
	display: 'grid',
	backgroundColor: themeColors.modalBackground,
	width: '100%',
	height: '100%',
	justifyContent: 'center',
	overflow: 'hidden',
	alignItems: 'center',
	},

Result:

pdfview.mp4

What alternative solutions did you explore? (Optional)

N/A

[kevinksullivan]

clarifying in slack

https://expensify.slack.com/archives/C049HHMV9SM/p1692917109070339?thread_ts=1691710745.839059&cid=C049HHMV9SM

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0103449447ce220c8a

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.