[HOLD for payment 2023-09-29] [$1000] Task - Chat report for task assignee disappears from LHN when logged in on a different session

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify,com
2. Create new account A & B on web browser.
3. As User A, initiate a chat with User B.
4. As User A, assign a task to to User A but share it in User B's chat.
5. As User A, complete the task.
6. As User B on web browser, verify that the new chat from User A exists, log out while leaving the chat unread (don't open it).
7. As User B, log in on a different platform like mweb, Android or desktop app. If using web, please clear the browser session entirely (close and reopen incognito window)

Expected Result:

Chat report from User A will remain in LHN

Actual Result:

Chat report from User A disappears from LHN when logged in on a different session

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.56-7

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173876_bandicam_2023-08-23_03-38-12-587.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179eb890f49bf0a87
• Upwork Job ID: 1694471428963811328
• Last Price Increase: 2023-09-06
• Automatic offers:
• s-alves10 | Contributor | 26687142

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0179eb890f49bf0a87

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat report for task assignee disappears from LHN when log in on another device

What is the root cause of that problem?

Suppose that user A opens a new chat with user B.
When user A sends message or does some actions like create task, user B receives pusher events for those actions and so user B would have report actions for that report(chat between user A and user B). But when a user log out and log in again, we call openApp or reconnectApp API but these APIs doesn't return actions of the report that the user haven't ever visited. So in this case, the report actions of the new chat would be empty

This makes the new report filtered out by the below line when getting LHN list

App/src/libs/ReportUtils.js

Line 2617 in 329cac3

const isEmptyChat = !lastVisibleMessage.lastMessageText && !lastVisibleMessage.lastMessageTranslationKey;

App/src/libs/ReportUtils.js

Lines 2646 to 2648 in 329cac3

	if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report)) {
	return false;
	}

This is the root cause

What changes do you think we should make in order to solve the problem?

We determines if the report is empty by checking the last visible action of the report below

App/src/libs/ReportUtils.js

Lines 2616 to 2617 in 329cac3

	const lastVisibleMessage = ReportActionsUtils.getLastVisibleMessage(report.reportID);
	const isEmptyChat = !lastVisibleMessage.lastMessageText && !lastVisibleMessage.lastMessageTranslationKey;

We have the same data in the report(lastMessageText and lastMessageTranslationKey)
We can do the check by using the report

        const isEmptyChat = !report.lastMessageText && !report.lastMessageTranslationKey;

This works fine as expected

What alternative solutions did you explore? (Optional)

We can check if the report is empty by using both report and last visible action. But I think checking by report is enough

[lschurr]

@sobitneupane could you review the proposal here?