[HOLD for payment 2023-10-16] [$1000] Web - Chat - Hover effect lost after opening popover again before closing it.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Open the pop over right clicking
3. Move the pointer to the left or the right and right click again.

Expected Result:

The hover effect is present

Actual Result:

The hover effect is lost

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-7

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-11.At.12.12.21.Pm.mp4

20230821_200158.mp4

Expensify/Expensify Issue URL:

Issue reported by: @getusha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691745427354299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c432588dbb79d8dd
• Upwork Job ID: 1693717160574693376
• Last Price Increase: 2023-09-11
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26972863
• getusha | Contributor | 26972865
• getusha | Reporter | 26972866

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover effect lost after opening context menu popover again before closing the opened one.

What is the root cause of that problem?

We are passing toggleContextMenuFromActiveReportAction as onHide argument, which will make the isContextMenuActive false, currently we are passing empty function to be triggered for onShow param.

App/src/pages/home/report/ContextMenu/ReportActionContextMenu.js

Lines 59 to 60 in 4a7558c

	onShow = () => {},
	onHide = () => {},

App/src/pages/home/report/ReportActionItem.js

Lines 226 to 227 in 4a7558c

	() => {},
	toggleContextMenuFromActiveReportAction,

when we set isContextMenuActive to true here, when the previous context menu closes it will replace our true value with false. because onHide is triggered after the new isContextMenuActive update.

What changes do you think we should make in order to solve the problem?

We should set isContextMenuActive to true onShow instead of calling it here:

App/src/pages/home/report/ReportActionItem.js

Line 215 in 4a7558c

setIsContextMenuActive(true);

We should move setIsContextMenuActive to here, to be triggered onShow after onHide is called. this will insure it has the updated value.

App/src/pages/home/report/ReportActionItem.js

Line 226 in 4a7558c

() => {},

() => setIsContextMenuActive(true),

Result:

Screen.Recording.2023-08-21.at.5.57.56.PM.mov

What alternative solutions did you explore? (Optional)

[Pujan92]

onHide is triggered after the new isContextMenuActive update

@getusha I am about to propose the same solution but just wanted to understand the above point.

[getusha]

@Pujan92

App/src/pages/home/report/ReportActionItem.js

Line 215 in 4a7558c

setIsContextMenuActive(true);

after the above update onHide will be triggered for the previous context menu then the new popover shows right? Once the onHide function is triggered, it will set the state to false, overriding the updated value which was set before opening the popover.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c432588dbb79d8dd

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)