[$1000] Web - Assign Task - The emoti icons do not work in chat for task

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click Assign Task in FAB.
2. Add a new task.
3. Mark the task as done.
4. You will get the chat 'completed task '
5. Click emoti icons on 'completed task '

Expected Result:

The emoti icons should work.

Actual Result:

The emoti icons do not work.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.54-11

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-08-02_17-48-30.mp4

2023-08-09_15-21-10.mp4

Recording.1153.mp4

Expensify/Expensify Issue URL:

Issue reported by: @oleksandr-pantsyr

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690987850797129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01121b95215b1e98f4
• Upwork Job ID: 1691914725035556864
• Last Price Increase: 2023-08-16

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emojis and emojiPickers shown on task completed, reopened messages but cannot be selected

What is the root cause of that problem?

Here

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 46 in b3789c9

shouldShow: (type, reportAction) => type === CONTEXT_MENU_TYPES.REPORT_ACTION && _.has(reportAction, 'message') && !ReportActionUtils.isMessageDeleted(reportAction),

we show the quick emoji reactions if the reportaction has a message and it is not deleted so it appears for the task completion and reopening messages
Presently reactions are not added and displayed because here

App/src/libs/actions/Report.js

Line 1675 in 202f2eb

const originalReportID = ReportUtils.getOriginalReportID(reportID, reportAction);

we get the originalReportID which gives a different reportID (the parentReport chat in which this task appears as a reportAction in a report) if it is isThreadFirstChat
and the isThreadFirstChat here

App/src/libs/ReportUtils.js

Line 687 in 202f2eb

return !_.isUndefined(reportAction.childReportID) && reportAction.childReportID.toString() === reportID;

gives a different report ID for the reportActions of "completed task" etc because they have a childReportID but this different reportID does not have these report actions of “completed task” etc.
So originalReportAction here is an empty object and the function returns without adding emoji to the reportAction.

App/src/libs/actions/Report.js

Line 1678 in 202f2eb

if (_.isEmpty(originalReportAction)) {

What changes do you think we should make in order to solve the problem?

So we need to add at the end of the isThreadFirstChat check this

reportAction.childType !== CONST.REPORT.TYPE.TASK

or

reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED ||
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED ||
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED

then the originalReportID stays as the actual reportID and we can react on these messages also and they get reflected.

What alternative solutions did you explore? (Optional)

We can add this condition here in shouldShow in ContextActionsMenu to prevent the quick reaction menu from showing altogether similar to the copyToClipboard condition in the menu.

reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED ||
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED ||
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED

Result

Screen.Recording.2023-08-09.at.10.07.47.PM.mov

[adelekennedy]

I can reproduce - In the parent thread I'm able to react but not in the completed task thread. Agree with the thread let's polish this so that either no emoji menu shows up in the completed task thread - or it allows reactions. I think the first option is cleaner

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01121b95215b1e98f4

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Assign Task - The emoti icons do not work in chat for task

What is the root cause of that problem?

whenever task completed or reopened childReportID is have. so that its getting childReportID instead of ReportID
https://github.com/tienifr/App/blob/5b37315863b28edcdd5e16b63c29012a222a575b/src/libs/ReportUtils.js#L2268
here
this pr added this
https://github.com/Expensify/App/pull/20574/files

What changes do you think we should make in order to solve the problem?

https://github.com/tienifr/App/blob/5b37315863b28edcdd5e16b63c29012a222a575b/src/libs/ReportUtils.js?#L2269

function getOriginalReportID(reportID, reportAction) {
    return isThreadFirstChat(reportAction, reportID) && ![CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED, CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED, CONST.REPORT.ACTIONS.TYPE.TASKREOPENED].includes(reportAction.actionName) ? lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, 'parentReportID']) : reportID;
}

for completely removing the emoji
https://github.com/tienifr/App/blob/5b37315863b28edcdd5e16b63c29012a222a575b/src/pages/home/report/ContextMenu/ContextMenuActions.js?#L45

                shouldShow: (type, reportAction) => type === CONTEXT_MENU_TYPES.REPORT_ACTION && _.has(reportAction, 'message') && !ReportActionUtils.isMessageDeleted(reportAction) && ![CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED, CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED, CONST.REPORT.ACTIONS.TYPE.TASKREOPENED].includes(reportAction.actionName),