[HOLD for payment 2023-09-27] [HOLD for #26747] [$1000] Request money - Amount is partially covered by top selection menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue found when executing PR #23698

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with an expensifail account
3. Tap the green plus button
4. Tap on "Request money"

Expected Result:

Amount should be fully visible

Actual Result:

The amount is partially covered by top selection menu (because of the banner on top of the screen)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.54.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6166123_Krst4127_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152c32e49ad0a8a1b
• Upwork Job ID: 1691855787116150784
• Last Price Increase: 2023-08-16
• Automatic offers:
• tienifr | Contributor | 26249176

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[himanshuragi456]

what should be the fix?
either we'll have to reduce some element sizes or we can remove options on the top

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money - Amount is partially covered by top selection menu

What is the root cause of that problem?

Space is not enough for all the things to render. We're not wrapping our MoneyRequestForm inside a ScrollView and are relying on just the screen height to display everything.

What changes do you think we should make in order to solve the problem?

We need to conditionally replace the Fragment defined here with the following, only if isEditing is false.

<ScrollView contentContainerStyle={[styles.flexGrow1, styles.flexColumn]}>

Result

Screen.Recording.2023-08-16.at.2.37.20.AM.mov

What alternative solutions did you explore? (Optional)

None

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money - Amount is partially covered by top selection menu

What is the root cause of that problem?

The height of each button is too big (minHeight: 52px), so in the small screen we don't have enough space to show the amount

What changes do you think we should make in order to solve the problem?

We should calculate the height for the button base on the percentage. In order to do that we can lean on heightPercentageToDP from react-native-responsive-screen

// 812 is the default screen height
// value is the height that we want to be in the default screen
export const responsiveByHeight = (value: number, referenceScreenHeight: number = 812) => {
    return heightPercentageToDP((value / referenceScreenHeight) * 100);
};

In

App/src/components/BigNumberPad.js

Line 72 in 0bdf183

<Button

we can add these lines

innerStyles={[{
    minHeight:responsiveByHeight(variables.componentSizeLarge) // we can change the size here
}]}

Note: this approach won't change the heigh when we change the screen height dynamically, but I think it's fine because we can only use BigNumberPad on mweb or native, and we don't have any ways to change the screen height dynamically.

If we still want to do that, we can build the heightPercentageToDP by ourself. The idea is the same as heightPercentageToDP from react-native-responsive-screen, it is to calculate the height base on the percentage and the screen height (get from withWindowDimensions)

What alternative solutions did you explore? (Optional)

None

Result

Screen.Recording.2023-08-17.at.15.20.11.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152c32e49ad0a8a1b

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)