[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Make money request from account A to account B
2. Click on the IOU preview component twice
3. Click on the amount and change it
4. Hover over the posted comment and click on copy to clipboard
5. Paste the content elsewhere

Expected Result:

The content should be copied when clicking on the copy to clipboard icon

Actual Result:

Nothing gets copied when clicking the copy to clipboard icon

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.54-7

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

-14993053652749344022023-08-14_23_41_07.MP4

Recording.1201.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692045636871669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015fd8284ce80abac6
• Upwork Job ID: 1691425057366032384
• Last Price Increase: 2023-08-15
• Automatic offers:
• hungvu193 | Contributor | 26158030
• Nathan-Mulugeta | Reporter | 26158033

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment

What is the root cause of that problem?

We're using this code below to copy message to clipboard, since we introduced new type of reportAction called "MODIFIEDEXPENSE", we didn't format it before copying, which caused the issue

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 187 to 205 in 56f0b0f

	const isAttachment = _.has(reportAction, 'isAttachment') ? reportAction.isAttachment : ReportUtils.isReportMessageAttachment(message);
	if (!isAttachment) {
	const content = selection || messageHtml;
	if (isReportPreviewAction) {
	const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(reportAction));
	const displayMessage = ReportUtils.getReportPreviewMessage(iouReport, reportAction);
	Clipboard.setString(displayMessage);
	} else if (content) {
	const parser = new ExpensiMark();
	if (!Clipboard.canSetHtml()) {
	Clipboard.setString(parser.htmlToMarkdown(content));
	} else {
	const plainText = parser.htmlToText(content);
	Clipboard.setHtml(content, plainText);
	}
	}
	} else {
	Clipboard.setString(messageHtml);
	}

What changes do you think we should make in order to solve the problem?

We should update our copy to clip board action, if it's isModifiedExpenseAction, we should format the message before copying by adding more condition here:

else if (ReportActionUtils.isModifiedExpenseAction(reportAction)) {
const displayMessage = ReportUtils.getModifiedExpenseMessage(reportAction);
Clipboard.setString(displayMessage);
}

We should also update our shouldShow condition of copyToClipboard to make it show with ReportPreview TaskPreview:

    shouldShow: (type, reportAction) =>
        type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED &&
        !ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}]))) &&
        !ReportActionUtils.isMessageDeleted(reportAction),

In order to show copy option with task, we can also remove these three condition from above condition:

        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED &&

What alternative solutions did you explore? (Optional)

N/A