[$1000] Preview load every time when receive any image

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. click on FAB icon and select new chat option
2. create a new chat with user
3. send a image to user
4. on receiver side click on image to see preview
5. from sender send a new image

Expected Result:

preview loads for a seconds on receive any new image

Actual Result:

preview does not load
Platforms: Web

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5825.mp4

Screen.Recording.2023-08-05.at.11.48.02.AM.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691216620506039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010173971d7c24dc56
• Upwork Job ID: 1694035230172463104
• Last Price Increase: 2023-10-03

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aditygrg2]

Not reproducible.

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Preview load every time when receive any image.

What is the root cause of that problem?

When the sender sends a new image, on the receiver side, app receives the push event, and then the following code is executed.

App/src/components/Attachments/AttachmentCarousel/index.js

Line 31 in a03a21d

const {attachments, initialPage, initialActiveSource, initialItem} = useMemo(() => extractAttachmentsFromReport(report, reportActions, source), [report, reportActions, source]);

But initialItem is an object that contains file, isAuthTokenRequired, source fields, and is defined inside the component.
As a result, this dependency is always different on a re-render, and then cause the following effect to re-run.

App/src/components/Attachments/AttachmentCarousel/index.js

Lines 33 to 38 in a03a21d

	useEffect(() => {
	// Update the parent modal's state with the source and name from the mapped attachments
	if (!initialItem) return;
	onNavigate(initialItem);
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [initialItem]);

So onNavigate is called, and then onCarouselAttachmentChange is called.

App/src/components/AttachmentModal.js

Lines 117 to 125 in 8e799df

	const onNavigate = useCallback(
	(attachment) => {
	setSource(attachment.source);
	setFile(attachment.file);
	setIsAuthTokenRequired(attachment.isAuthTokenRequired);
	onCarouselAttachmentChange(attachment);
	},
	[onCarouselAttachmentChange],
	);

App/src/pages/home/report/ReportAttachments.js

Lines 34 to 37 in 8e799df

	onCarouselAttachmentChange={(attachment) => {
	const route = ROUTES.getReportAttachmentRoute(reportID, attachment.source);
	Navigation.navigate(route);
	}}

Therefore preview load every time when receive image.

What changes do you think we should make in order to solve the problem?

We can modify useEffect dependency to initialItem?.source in this line and this line.

    useEffect(() => {
        ...
    }, [initialIsActive?.source]);

Or we can define new variable that takes initialIsActive?.source and add this variable to the dependency instead of initialIsActive.

What alternative solutions did you explore? (Optional)

None.

[muttmuure]

I'm not sure I understand what the problem is here

[StevenKKC]

@muttmuure Please check second video. Each time send a new image, preview will be reloaded on the receiver side.
I think Expected result and Actual result are swapped.

[melvin-bot]

@muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010173971d7c24dc56