[$1000] iOS - Deepliink - Keyboard displayed upon splash screen if open new chat deeplink

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #24126

Action Performed:

Precondition - Make sure that the app is completely closed (killed) and doesn't run in the background

1. Tap on https://staging.new.expensify.com/new/chat
   deeplink (e.g. in notes)

Expected Result:

"New chat" tab and keyboard appear after splash screen is dismissed

Actual Result:

Keyboard appears upon loading splash screen.
In Production the issue is reproducible when user interacts with staging deeplinks. If user taps on production deeplinks they will land in mWeb, not iOS app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6161781_IMG_8918.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100e6a84621057a16
• Upwork Job ID: 1691899029638578176
• Last Price Increase: 2023-10-18
• Automatic offers:
• jjcoffee | Reviewer | 27364778
• tienifr | Contributor | 27364780

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user taps on a deep link to open the "New Chat" page in the app, the keyboard appears upon loading the splash screen. The expected behavior is for the "New Chat" tab and keyboard to appear only after the splash screen is dismissed.

What is the root cause of that problem?

The shouldFocusOnSelectRow prop of the OptionsSelector component within the NewChatPage is set to true immediately upon rendering, triggering the keyboard to display.

App/src/pages/NewChatPage.js

Line 201 in a03a21d

shouldFocusOnSelectRow={props.isGroupChat && !Browser.isMobile()}

What changes do you think we should make in order to solve the problem?

Use React's Context API to modify the shouldFocusOnSelectRow prop based on the isSplashHidden state:

Create a New Context:

import { createContext } from 'react';

const AppContext = createContext();

export default AppContext;

Provide the Context in Expensify.js:

import AppContext from './path_to_AppContext';

// ... other code ...

return (
    <AppContext.Provider value={{ isSplashHidden }}>
        {/* Your existing components, including navigators */}
    </AppContext.Provider>
);

Consume the Context in NewChatPage.js:

import React, { useContext } from 'react';
import AppContext from './path_to_AppContext';

function NewChatPage(props) {
    const { isSplashHidden } = useContext(AppContext);

    // ... rest of your component logic ...
}

Modify the shouldFocusOnSelectRow Prop:

Update the prop in the OptionsSelector component:

<OptionsSelector
    ...
    shouldFocusOnSelectRow={props.isGroupChat && !Browser.isMobile() && isSplashHidden}
    ...
/>

What alternative solutions did you explore? (Optional)

[isabelastisser]

I was assigned this when I was OOO. I will review this soon!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100e6a84621057a16

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)