Status - Two "Save" buttons, making one redundant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Sign into an expensifail account
3. Go to settings > Profile > Status
4. Click on Status > change the status and add an emoji > Click Save > Click Back

Expected Result:

User expects that if the "save" button is tapped, then the status will save automatically the first time around

Actual Result:

After hitting the save button for the first time then tapping back, the status is not saved. It is necessary to hit the "Save" button twice in a row for the status to be changed successfully

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6160865_Save_button_twice.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiroslav]

Custom status bugs are not blockers.
Context: https://expensify.slack.com/archives/C049HHMV9SM/p1691610130667239

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status - Two "Save" buttons, making one redundant

What is the root cause of that problem?

In both StatusSetPage and StatusPage we have Save button. The Save button in StatusSetPage only save status to draft, the Save button in StatusPage save it to our BE and clear draft.

What changes do you think we should make in order to solve the problem?

We can remove Save button on the first page StatusPage, so we can remove the footer props from StaticHeaderPageLayout here:

App/src/pages/settings/Profile/CustomStatus/StatusPage.js

Line 73 in cceb862

footer={footerComponent}

also remove redundant code related to footerComponent.

In StatusSetPage, we should update our onSubmit function to:

    const onSubmit = useCallback(
        (value) => {
            const endOfDay = moment().endOf('day').toDate();
            User.updateCustomStatus({text: value.statusText, emojiCode: value.emojiCode, clearAfter: endOfDay.toISOString()});

            Navigation.goBack(ROUTES.SETTINGS_STATUS);
        },
        [defaultText],
    );

What alternative solutions did you explore? (Optional)

N/A

[Li357]

Removing the deploy blocker label per https://expensify.slack.com/archives/C049HHMV9SM/p1691610130667239