[Waiting on BugZero Checklist] [$1000] Inconsistency bug: 'Go back to home screen' link is not present on 'Hmm its not here' page of archived workspace settings

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Create new workspace or open existing workspace
5. Click on settings and copy link, send to any report
6. Click on bank account and copy link, send to any report
7. Delete the workspace used in step 5 and 6
8. Open link copied in step 6 and observe that it has 'Go back to home screen' link
9. Open link copied in step 5 and observe that it does nor have 'Go back to home screen' link

Expected Result:

App should display 'Go back to home screen' link in 'Hmm its not here' page for all workspace pages after being archived

Actual Result:

App does not display 'Go back to home screen' link in 'Hmm its not here' page for settings page of workspace after being archived

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

does.not.display.go.back.to.homepage.link.mp4

Recording.2323.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691054147355909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d12ba5fc6e912485
• Upwork Job ID: 1690985977143230464
• Last Price Increase: 2023-08-14
• Automatic offers:
• GItGudRatio | Contributor | 26164949
• Dhanashree-Sawant | Reporter | 26164953

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Go back to home screen' link is not present on 'Hmm its not here' page of archived workspace settings.

What is the root cause of that problem?

All the Workspace Pages use the WorkspacePageWithSections for showing the FullPageNotFoundView. This component does not have the shouldShowLink prop, thus the 'Go back to home screen' text not showing up.

What changes do you think we should make in order to solve the problem?

We need to add the shouldShowLink prop here:

App/src/pages/workspace/WorkspacePageWithSections.js

Lines 106 to 110 in c08d588

	<FullPageNotFoundView
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
	shouldShow={_.isEmpty(policy) || !Policy.isPolicyOwner(policy)}
	subtitleKey={_.isEmpty(policy) ? undefined : 'workspace.common.notAuthorized'}
	>

What alternative solutions did you explore? (Optional)

N/A

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app should display 'Go back to home screen' link in 'Hmm its not here' page for all workspace pages after being archived

What is the root cause of that problem?

Currently in most workspace pages we have not added the shouldShowLink prop to how link back to home when using FullPageNotFoundView. Here for example

App/src/pages/workspace/WorkspacePageWithSections.js

Lines 106 to 110 in 4230f28

	<FullPageNotFoundView
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
	shouldShow={_.isEmpty(policy) || !Policy.isPolicyOwner(policy)}
	subtitleKey={_.isEmpty(policy) ? undefined : 'workspace.common.notAuthorized'}
	>

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 407 to 411 in 4230f28

	<FullPageNotFoundView
	shouldShow={_.isEmpty(props.policy) || !Policy.isPolicyOwner(props.policy)}
	subtitleKey={_.isEmpty(props.policy) ? undefined : 'workspace.common.notAuthorized'}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
	>

And some other pages of workspace

What changes do you think we should make in order to solve the problem?

We should look for places where FullPageNotFoundView is used in the workspace and add the shouldShowLink prop.

What alternative solutions did you explore? (Optional)

N/A

[DanutGavrus]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency bug: 'Go back to home screen' link is not present on 'Hmm its not here' page of archived workspace settings

What is the root cause of that problem?

For the Workspace Setting Page, we do not pass the prop shouldShowLink, so we don't see the button.

What changes do you think we should make in order to solve the problem?

1. If we want to show the link in the Settings Page, then, the WorkspaceSettingPage returns the WorkspacePageWithSections which is wrapped in the FullPageNotFoundView component. We should pass the shouldShowLink prop here.
2. If we want to remove the link from the bank account page, then we should remove the shouldShowLink prop from the ReimbursementAccountPage component.

We may consider the alternative solution here.

What alternative solutions did you explore?

1. Either: We have 24 usages of FullPageNotFoundView, and only 2 use the shouldShowLink as true: ReimbursementAccountPage(the positive example from this Issue) and TransferBalancePage. The other 22 do not use it. I would say, instead of fixing only 1, or some of them in this issue, to default shouldShowLink prop to true in order to prevent future bugs like this one, and pass it as false only where we really don't want to show it(if any). Otherwise, we may continue seeing Issues like Inconsistency: Go back to home link is not present in page x but is in page y until we reach consistency between all, which may be more time & money consuming.
2. Or: We have only 2 usages with true, we may remove those in order to reach consistency between all 24 usages, thus none will show the link.

It might also be a good idea to ask in Slack, or to ask the design team, about this alternative solution.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d12ba5fc6e912485

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)